Skip to content

Commit

Permalink
rebased
Browse files Browse the repository at this point in the history
  • Loading branch information
LucasMSg committed Sep 29, 2023
1 parent 049625d commit a4775de
Showing 1 changed file with 1 addition and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,8 @@ abstract contract TransferManager is ERC165Upgradeable, ITransferManager {
LibDeal.DealSide memory right,
LibFeeSide.FeeSide feeSide
) internal override {
<<<<<<< HEAD
if (feeSide == LibFeeSide.FeeSide.LEFT) {
doTransfersWithRoyalties(left, right);
=======
if (dealData.feeSide == LibFeeSide.FeeSide.LEFT) {
doTransfersWithFees(left, right, dealData.maxFeesBasePoint);
>>>>>>> format fix
transferPayouts(right.asset.assetType, right.asset.value, right.from, left.payouts);
} else if (feeSide == LibFeeSide.FeeSide.RIGHT) {
doTransfersWithRoyalties(right, left);
Expand All @@ -125,22 +120,11 @@ abstract contract TransferManager is ERC165Upgradeable, ITransferManager {
/// @notice executes the fee-side transfers (payment + fees)
/// @param paymentSide DealSide of the fee-side order
/// @param nftSide DealSide of the nft-side order
<<<<<<< HEAD
/// @return totalAmount of fee-side asset
function doTransfersWithRoyalties(
LibDeal.DealSide memory paymentSide,
LibDeal.DealSide memory nftSide
) internal returns (uint256 totalAmount) {
uint256 rest = paymentSide.asset.value;
=======
/// @param maxFeesBasePoint max fee for the sell-order (used and is > 0 for V3 orders only)
function doTransfersWithFees(
LibDeal.DealSide memory paymentSide,
LibDeal.DealSide memory nftSide,
uint256 maxFeesBasePoint
) internal {
uint256 rest = calculateTotalAmount(paymentSide.asset.value, paymentSide.originFees, maxFeesBasePoint);
>>>>>>> last changes
uint256 rest = paymentSide.asset.value;

rest = transferRoyalties(
paymentSide.asset.assetType,
Expand Down

1 comment on commit a4775de

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

58.98%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/marketplace/contracts/exchange
   AssetMatcher.sol83.10%76.67%100%86.49%49–50, 52, 55, 69–70, 70, 70–71, 73, 76–77
   Exchange.sol75%85%73.33%68%105–108, 182, 49, 90, 90–92, 98
   ExchangeCore.sol57.66%45.65%73.33%61.84%106–107, 122, 136–138, 145–146, 158, 173–174, 192–193, 193, 193, 193, 193, 195–196, 196, 196, 196, 196, 257–258, 260–261, 298, 300–302, 308–310, 333–334, 351, 368–369, 369, 369–370, 372–373, 375, 382, 382, 382–383, 385, 385, 385–386, 388
   OrderValidator.sol69.81%57.14%100%80.95%32, 48, 55–56, 56, 56, 66, 76–77, 82, 84, 84, 84, 84–85, 87
   WhiteList.sol97.62%93.75%100%100%51
packages/marketplace/contracts/exchange/libraries
   LibDirectTransfer.sol100%100%100%100%
   LibFill.sol55%33.33%66.67%63.64%48–49, 61, 71–72, 72, 72–73
   LibOrderDataGeneric.sol22.81%22.22%40%20.59%16–23, 25–26, 28, 41, 43, 43, 43–44, 46–47, 50, 50, 50–51, 53, 56, 56, 56–57, 59, 62, 66, 68, 68, 68–70, 73, 82, 82, 82–84
packages/marketplace/contracts/interfaces
   IAssetMatcher.sol100%100%100%100%
   IOrderValidator.sol100%100%100%100%
   IRoyaltiesProvider.sol100%100%100%100%
   IWhiteList.sol100%100%100%100%
packages/marketplace/contracts/lazy-mint/erc-1155
   IERC1155LazyMint.sol100%100%100%100%
   LibERC1155LazyMint.sol0%100%0%0%34–36, 38–40, 42
packages/marketplace/contracts/lazy-mint/erc-721
   IERC721LazyMint.sol100%100%100%100%
   LibERC721LazyMint.sol0%100%0%0%33–35, 37–39, 41
packages/marketplace/contracts/lib-asset
   LibAsset.sol100%100%100%100%
packages/marketplace/contracts/lib-bp
   BpLibrary.sol100%100%100%100%
packages/marketplace/contracts/lib-order
   LibMath.sol27.50%18.75%50%30%100–103, 17–18, 33–34, 50, 50, 50–51, 72, 72, 72–73, 75, 88, 88, 88–89, 93, 93, 93, 93, 93, 97
   LibOrder.sol66.67%50%100%72.73%105, 105, 107, 107, 41–43, 54, 66
   LibOrderData.sol100%100%100%100%
packages/marketplace/contracts/lib-part
   LibPart.sol0%100%0%0%21
packages/marketplace/contracts/royalties
   IERC2981.sol100%100%100%100%
   LibRoyalties2981.sol35.71%25%100%33.33%19, 22–23, 23, 23–27
packages/marketplace/contracts/royalties-registry
   IMultiRoyaltyRecipients.sol100%100%100%100%
   RoyaltiesRegistry.sol69.92%67.65%92.86%66.67%154, 160, 160, 160–161, 164, 164, 164–165, 168, 196–197, 206, 210, 226–227, 230–238, 241, 241, 241–242, 244, 250, 253, 267–268, 270, 54
packages/marketplace/contracts/transfer-manager
   TransferExecutor.sol27.18%21.74%80%26.92%102, 105–106, 111–112, 112, 112–113, 113, 113–114, 116, 119–120, 125–126, 126, 126–127, 135, 145–146, 150, 160, 194, 194, 194–195, 195, 195–196, 200–201, 201–202, 206, 52–54, 61–62, 62, 62, 66, 69–70, 74, 74–75, 75, 75–76, 78, 78, 80–82, 84, 90, 90, 90–91, 91, 91–92, 92, 92, 95–96, 96, 96–97, 97, 97
   TransferManager.sol70%56.90%100%74.44%111, 115–116, 150–152, 152, 152–153, 160–161, 196–198, 198, 198–199, 199, 199–200, 206–207, 207, 207–208, 212, 226–227, 231–233, 237, 264, 281, 285–287, 287, 287–289, 294–295, 318, 322–323, 83–84
packages/marketplace/contracts/transfer-manager/interfaces
   IRoyaltyUGC.sol100%100%100%100%
   ITransferExecutor.sol100%100%100%100%
   ITransferManager.sol100%100%100%100%
packages/marketplace/contracts/transfer-manager/lib
   LibDeal.sol100%100%100%100%
   LibFeeSide.sol46.15%41.67%100%46.15%15–16, 18–19, 24, 27, 27, 27–28, 30, 30, 30–31, 33
   LibTransfer.sol0%0%0%0%7–8, 8, 8

Please sign in to comment.