Skip to content

Commit

Permalink
test: fix broken test
Browse files Browse the repository at this point in the history
  • Loading branch information
adjisb authored and mvanmeerbeck committed Oct 9, 2023
1 parent 3167a31 commit 747e930
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/marketplace/test/exchange/OrderValidator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ describe('OrderValidator.sol', function () {

await expect(
OrderValidatorAsUser.validate(order, '0x', user1.address)
).to.be.revertedWith('contract order signature verification error');
).to.be.revertedWith('order signature verification error');
});

it('should validate when maker is contract but not sender and isValidSignature returns magic value', async function () {
Expand Down
5 changes: 3 additions & 2 deletions packages/marketplace/test/utils/order.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export type Order = {
};

export const OrderDefault = async (
maker: Signer,
maker: {getAddress: () => Promise<string>},
makeAsset: Asset,
taker: Signer | ZeroAddress,
takeAsset: Asset,
Expand All @@ -40,7 +40,8 @@ export const OrderDefault = async (
): Promise<Order> => ({
maker: await maker.getAddress(),
makeAsset,
taker: taker === ZeroAddress ? ZeroAddress : await taker.getAddress(),
taker:
taker === ZeroAddress ? ZeroAddress : await (taker as Signer).getAddress(),
takeAsset,
salt,
start,
Expand Down

1 comment on commit 747e930

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage for this commit

99.34%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
packages/marketplace/contracts/exchange
   Exchange.sol95.65%96.67%93.75%95.65%175, 63
   ExchangeCore.sol98.73%96.15%100%100%65
   OrderValidator.sol97.92%95.45%100%100%38
   WhiteList.sol97.62%93.75%100%100%64
packages/marketplace/contracts/exchange/libraries
   LibFill.sol100%100%100%100%
   LibMath.sol100%100%100%100%
packages/marketplace/contracts/interfaces
   IOrderValidator.sol100%100%100%100%
   IRoyaltiesProvider.sol100%100%100%100%
   IWhiteList.sol100%100%100%100%
packages/marketplace/contracts/lib-asset
   LibAsset.sol100%100%100%100%
packages/marketplace/contracts/lib-bp
   BpLibrary.sol100%100%100%100%
packages/marketplace/contracts/lib-order
   LibOrder.sol100%100%100%100%
packages/marketplace/contracts/lib-part
   LibPart.sol100%100%100%100%
packages/marketplace/contracts/royalties
   IERC2981.sol100%100%100%100%
   LibRoyalties2981.sol100%100%100%100%
packages/marketplace/contracts/royalties-registry
   IMultiRoyaltyRecipients.sol100%100%100%100%
   RoyaltiesRegistry.sol96.58%90%100%98.61%166–167, 239, 60
packages/marketplace/contracts/transfer-manager
   TransferExecutor.sol100%100%100%100%
   TransferManager.sol99.11%97.06%100%100%63
packages/marketplace/contracts/transfer-manager/interfaces
   IRoyaltyUGC.sol100%100%100%100%
   ITransferExecutor.sol100%100%100%100%
   ITransferManager.sol100%100%100%100%

Please sign in to comment.