Skip to content

feat: fix/remove todos #5855

feat: fix/remove todos

feat: fix/remove todos #5855

Triggered via push September 28, 2023 20:06
Status Failure
Total duration 4m 1s
Artifacts

main.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
deploy
Process completed with exit code 1.
coverage
43.58638743455497 is less than min_coverage 80 Lines not covered: - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/AssetMatcher.sol: 50, 51, 53, 59, 74, 75, 77, 81 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/Exchange.sol: 95, 96, 102, 109, 110, 111, 112, 194 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/ExchangeCore.sol: 129, 130, 145, 159, 160, 161, 168, 169, 181, 196, 197, 216, 219, 268, 269, 272, 273, 274, 276, 279, 280, 282, 310, 313, 379, 380, 381, 382, 383, 385, 386, 388, 390, 392, 403, 406, 407, 411, 412, 415, 442, 450, 474, 508, 509, 510, 512, 513, 515, 522, 523, 525, 526, 528 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/libraries/LibFill.sol: 49, 71, 72, 73 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/libraries/LibOrderDataGeneric.sol: 19, 20, 21, 22, 23, 25, 26, 27, 28, 31, 46, 48, 49, 51, 52, 55, 56, 58, 61, 62, 64, 67, 71, 73, 74, 75, 78, 87, 88, 89 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/LibFillTest.sol: 17 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/LibOrderTest.sol: 13, 17, 21, 25, 35, 47 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/MockTrustedForwarder.sol: 14, 17, 18, 19 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/SimpleTransferManager.sol: 13, 14, 15, 16 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/TestAssetMatcher.sol: 12, 13, 14, 15, 16, 19 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/TestERC1271.sol: 24, 28 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/TestMinimalForwarder.sol: 12, 13, 14, 15, 16 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/TestRoyaltiesRegistry.sol: 21, 22, 23, 24, 25, 26, 28, 29, 33, 39, 43, 45, 46, 50, 62, 63, 64, 65, 66, 67, 68, 70, 71 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/ERC2981.sol: 38, 45, 47, 48, 51, 53, 62, 74, 75, 77, 84, 96, 97, 99, 106 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/MintableERC1155.sol: 10, 14 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/MintableERC1155WithRoyalties.sol: 9, 13, 17, 21, 25 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/MintableERC20.sol: 10 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/MintableERC721.sol: 10 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/mocks/tokens/MintableERC721WithRoyalties.sol: 9, 13, 17, 21, 25 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/exchange/OrderValidator.sol: 56, 77, 85, 87 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/lazy-mint/erc-1155/LibERC1155LazyMint.sol: 34, 35, 36, 38, 39, 40, 42 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/lazy-mint/erc-721/LibERC721LazyMint.sol: 33, 34, 35, 37, 38, 39, 41 - /home/runner/work/sandbox-smart-contracts/sandbox-smart-contracts/packages/marketplace/contracts/lazy-mint/mocks/ERC1155
coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: romeovs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/