Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AuthorizeRequest.php #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jupediaz
Copy link

@jupediaz jupediaz commented Mar 5, 2020

According Stripe official documentation and also responses from the Stripe API, there was a mistake on the application_fee parameter. It should be application_fee_amount.

This is a real response from Stripe API, about this incorrect parameter:

{
  "error": {
    "code": "parameter_unknown",
    "doc_url": "https://stripe.com/docs/error-codes/parameter-unknown",
    "message": "Received unknown parameter: application_fee. Did you mean application_fee_amount?",
    "param": "application_fee",
    "type": "invalid_request_error"
  }
}

Please, approve this Pull Request to have this solved and working.

Thank you very much.

According Stripe official documentation and also responses from the Stripe API, there was a mistake on the application_fee parameter. It should be application_fee_amount.
@jupediaz
Copy link
Author

jupediaz commented Mar 6, 2020

Travis CI tests seems are failing but it's not related with the change I proposed on the pull request. I suggest a manual check on the code as I think it's ok to approve this change.

@tafid
Copy link

tafid commented May 27, 2020

According Stripe official documentation and also responses from the Stripe API, there was a mistake on the application_fee parameter. It should be application_fee_amount.

This is a real response from Stripe API, about this incorrect parameter:

{
  "error": {
    "code": "parameter_unknown",
    "doc_url": "https://stripe.com/docs/error-codes/parameter-unknown",
    "message": "Received unknown parameter: application_fee. Did you mean application_fee_amount?",
    "param": "application_fee",
    "type": "invalid_request_error"
  }
}

Please, approve this Pull Request to have this solved and working.

Thank you very much.

Hi! According Stripe official documentation and Core Resource section, the Charge object may consist both application_fee and application_fee_amount attributes. May be we should just add application_fee_amount instead to change application_fee attribute?

@alexsegura
Copy link

alexsegura commented Aug 18, 2020

@tafid no, when creating a charge, Stripe expects the application_fee_amount property in the payload (see Creating a Charge). The application_fee exists once the Charge has been captured.

@barryvdh would it be possible to merge this PR, please?
It's quite critical for people implementing Stripe Connect for marketplaces.

Hmmm, the application_fee VS application_fee_amount seems to depend on the Stripe API version you are using 🤔
I'm looking at my Stripe API logs, and actually, I'm sending application_fee, and it works. I'm using the version 2019-09-09. Which version of the API are you using @jupediaz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants