Better support for Dynamic 3D Secure workflow with Stripe Elements #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Client Secret and the `use_stripe_sdk` next action type.
fotomerchant
changed the title
miholeus
reviewed
Oct 18, 2019
Comment on lines
-351
to
355
| if ($this->getConfirm()) { | ||
| $this->validate('returnUrl'); | ||
| if ($this->getConfirm() && $this->getReturnUrl()) { | ||
| $data['return_url'] = $this->getReturnUrl(); | ||
| } |
There was a problem hiding this comment.
Maybe it's better to write it like this?
if ($this->getReturnUrl()) {
$data['confirm'] = 'true';
}
If you set return_url, then confirm should be true according to stripe docs https://stripe.com/docs/api/payment_intents/create#create_payment_intent-return_url . It's better to set it by auto, I think.
domis86
suggested changes
Oct 18, 2019
| * $response->redirect(); | ||
| * $response->redirect(); | ||
| * } else if ($response->isStripeSDKAction()) { | ||
| * $client_secret = $response->getClientSecret(); |
There was a problem hiding this comment.
This should be returned in response so client application (javascript etc) can use it.
Can you add comment about it here?
|
Is this still required? |
Yes. As it stands, you are unable to (easily)perform the 3DS flow without redirecting away from your site with this package. |
|
@barryvdh any progress in merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding #152