Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to update a charge #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add the ability to update a charge #119

wants to merge 3 commits into from

Conversation

chrisnharvey
Copy link

The Stripe API supports updating a charge (https://stripe.com/docs/api/charges/update)

This PR adds support for this as requested in #94

@chrisnharvey
Copy link
Author

@barryvdh

Would someone be able to take a look at this :)

@chrisnharvey
Copy link
Author

Sorry to be a pain, but will someone be able to take a look at this soon?

@hiqsol
Copy link

hiqsol commented May 27, 2020

@chrisnharvey please fix the merge conflict

@chrisnharvey
Copy link
Author

Looks like void and refund have been removed from that class. I've merged master and resolved the conflicts.

@hiqsol hiqsol mentioned this pull request May 29, 2020
Open
chargePanelAndreas
chargePanelAndreas reviewed Jan 16, 2024
View reviewed changes
Copy link

@chargePanelAndreas chargePanelAndreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, just fix the return type as commented

src/Gateway.php
*
* @param array $parameters
*
* @return \Omnipay\Stripe\Message\Response
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be
* @return \Omnipay\Stripe\Message\UpdateChargeRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargePanelAndreas chargePanelAndreas chargePanelAndreas left review comments

@tafid tafid tafid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisnharvey @hiqsol @tafid @chargePanelAndreas