-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use INSTALL_TARGET_PROCESSES in Makefile #8
Conversation
Thanks for working on this. Can you change it a bit so as to place Taking the tweak example: include @@THEOS@@/makefiles/common.mk
TWEAK_NAME = @@PROJECTNAME@@
@@PROJECTNAME@@_FILES = Tweak.xm
include $(THEOS_MAKE_PATH)/tweak.mk It would become: include @@THEOS@@/makefiles/common.mk
TWEAK_NAME = @@PROJECTNAME@@
@@PROJECTNAME@@_FILES = Tweak.xm
INSTALL_TARGET_PROCESSES = @@KILL_PROCS@@
include $(THEOS_MAKE_PATH)/tweak.mk |
Yes, I'll do that. An afterthought: Would
I do not think I understand, sorry. Does perl have an array indicator, that which I am not using? I tested this PR by listing multiple processes in NIC ( |
Note due to the ifeq I use to check INSTALL_TARGET_PROCESSES is non-empty, it has to be set before including common.mk. I could change that to be tested using a shell |
At the time I was not aware that the check happened in common.mk. I apologize for the confusion. |
No reason for apologies, I feel this was a productive discussion; additionally, I apologize, as I did not intend to "point any fingers", as to say. If I may recommend, as @kirb mentioned, I think the variable should be a "per-instance var", as he described- similar to the |
Merged via rebase in 48854f2, moved the |
As per #2 (mark 5): "Make templates use ... INSTALL_TARGET_PROCESSES to kill processes instead of adding the rule at the bottom."