Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can_be_connected column added to BDNS_Abbreviations_Register.csv #225

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

TheFridgeShaman
Copy link
Collaborator

Added a "can_be_connected" column to BDNS_Abbreviation_Register.csv.
1 for assets that have connectivity capability and 0 for the ones that don't.
To be reviewed and updated with any new additions that happened on the master branch.
@jgunstone for visibility.

@jgunstone
Copy link
Collaborator

thanks the mention -
looks good to me.

FYI just checked and can_be_connected already exists in the README.md indicating the purpose of this column.

BDNS/README.md

Lines 30 to 37 in 9c1b38a

The [register of building device type abbreviations](BDNS_Abbreviations_Register.csv) includes the following columns:
* `asset_description` - a desription of what is named; the description typically includes a category when the level of granularity of the abbreviation is more specific
* `asset_abbreviation` - the BDNS abbreviation itself
* `can_be_connected` - a boolean value that distinguishes between assets that do not include any means of network connectivity and connectable devices
* `dbo_entity_type` - the [Digital Buildings Ontology](https://github.com/google/digitalbuildings) namespace and entity type that can be associated to the BDNS abbreviation; NOTE: while BDNS presupposes that modelers will apply abbreviations consistently based on similar domain expertise, DBO does not; instead, it provides definitions for devices which may have overlapping function or where terms are ambiguous. For example, while a BDNS user may find the distinction between AHU, ACU, and RTU to be meaningful, DBO does consider all of these as classes of AHU (and provides a definition for what an AHU is.
* `ifc_class` - the [IFC](https://technical.buildingsmart.org/standards/ifc/ifc-schema-specifications/) class that can be associated to the BDNS abbreviation
* `ifc_type` - the specific [IFC](https://technical.buildingsmart.org/standards/ifc/ifc-schema-specifications/) type associated to the IFC class that can be associated to the BDNS abbreviation

jgunstone and others added 2 commits April 10, 2024 16:29
@RitaLav RitaLav merged commit 69d5c78 into master Apr 10, 2024
1 check passed
@jgunstone jgunstone deleted the can_be_connected branch July 3, 2024 10:38
@jgunstone jgunstone restored the can_be_connected branch July 3, 2024 10:38
@jgunstone jgunstone deleted the can_be_connected branch September 4, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants