-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Shell attributes to arrays #371
Conversation
Reviewer's Guide by SourceryThis pull request converts Shell class attributes from lists to numpy arrays, making them consistent with the IOData class. It introduces a converter function for these attributes and updates the test cases to use assert_equal for comparisons. Additionally, Shell instantiation in some test files is modified to use lists instead of numpy arrays. File-Level Changes
Tips
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
This is a small step in #191. (I'm splitting things up from a larger change, to keep things bite size.)
This is a technical change to facilitate next steps in #191. It also makes array attributes in the
Shell
class consistent with the way they are implemented in theIOData
class.Summary by Sourcery
This pull request converts the Shell class attributes from lists to numpy arrays to ensure consistency with the IOData class. It also updates the relevant test cases to reflect these changes.