Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __all__ immutable #354

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Make __all__ immutable #354

merged 1 commit into from
Jun 29, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 28, 2024

This is one on the list in #204, just a minor cleanup, to avoid making such changes along the way in future pull requests.

Making all a tuple is not a tradition in Python, but makes sense for things that are not supposed to be variable.

I will YOLO-merge this on Friday, June 5, unless reviewed earlier.

Copy link

deepsource-io bot commented Jun 28, 2024

Here's the code health analysis summary for commits 8cf1132..da392b4. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me.

@tovrstra
Copy link
Member Author

Thanks, merging...

@tovrstra tovrstra merged commit 0ca750f into theochem:main Jun 29, 2024
12 checks passed
@tovrstra tovrstra deleted the all-immutable branch June 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants