Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to central contributing guide and add code of conduct #339

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

tovrstra
Copy link
Member

This is my suggestion to refer to the contributing guide in the .github repository proposed in theochem/.github#6

For the bigger picture, see #313

Copy link
Contributor

sourcery-ai bot commented Jun 17, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 17, 2024

Here's the code health analysis summary for commits d4bb73f..ba2ca35. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@tovrstra tovrstra mentioned this pull request Jun 17, 2024
@tovrstra
Copy link
Member Author

Tests fail due to the recent release of NumPy 2. We'll need to fix this first to get all tests on the rails again.

@tovrstra tovrstra added this to the 1.0.0 milestone Jun 17, 2024
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Toon.

@tovrstra
Copy link
Member Author

Thanks for reviewing...

@tovrstra tovrstra merged commit a127856 into theochem:main Jun 18, 2024
12 checks passed
@tovrstra tovrstra deleted the contrib-centralize branch June 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants