Fix warning due to line iterator __del__

[tovrstra]

The fixed code caused warnings, essentially due to an antipattern. One should use context managers to clean up resources, instead of doing so in the __del__ method. See #313 for the bigger picture.

I'm planning to YOLO-merge this on Thursday, June 13 unless reviewed earlier.

Summary by Sourcery

This pull request addresses a warning related to resource cleanup by refactoring the LineIterator class to use a context manager instead of the __del__ method. The changes include updates to the class implementation, modifications to the usage in various parts of the codebase, and adjustments to the test cases to align with the new context manager approach.

• Bug Fixes:
  • Fixed resource cleanup warning by replacing the use of __del__ method with context manager in LineIterator class.
• Enhancements:
  • Refactored LineIterator class to be used as a context manager, improving resource management and code readability.
• Tests:
  • Updated test cases to use the LineIterator class as a context manager, ensuring proper resource cleanup during tests.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a warning caused by the use of the __del__ method in the LineIterator class. The changes involve refactoring the LineIterator class to use context managers for resource cleanup, updating the usage of LineIterator across various files, and ensuring that the file handles are properly managed.

File-Level Changes

Files	Changes
iodata/api.py iodata/test/test_qchemlog.py iodata/test/test_wfx.py iodata/test/test_molden.py iodata/test/test_wfn.py	Updated various functions and tests to use LineIterator as a context manager.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[deepsource-io]

Here's the code health analysis summary for commits 4437bbf..b1367f7. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Python	✅ Success	🎯 1 occurence resolved	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sourcery-ai]

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 6 issues found
• 🟡 Complexity: 1 issue found

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[PaulWAyers]

Seems OK to me.

[tovrstra]

Thanks. Last one for today....