Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TagDetail): Hide tag feed tabs when no hottest articles #4961

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

Kechicode
Copy link
Contributor

No description provided.

@Kechicode Kechicode requested a review from a team as a code owner November 27, 2024 10:15
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:35am

@@ -15,6 +15,9 @@ const tagFragment = gql`
}
...ArticleCountTag
...TagBookmarkButtonTagPrivate
hottestArticles: articles(input: { first: 10, sortBy: byHottestDesc }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use first: 0 instead

@Kechicode Kechicode merged commit 2c7f103 into develop Nov 27, 2024
5 of 6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/revise-tag-tabs branch November 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants