Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turnstile): Use Cloudflare Turnstile instead of Google reCAPTCHA #3839

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat(turnstile): Use Cloudflare Turnstile instead of Google reCAPTCHA #3839

merged 1 commit into from
Oct 4, 2023

Conversation

tx0c
Copy link
Contributor

@tx0c tx0c commented Sep 22, 2023

resolves #3313

@tx0c tx0c requested a review from a team as a code owner September 22, 2023 07:25
@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 6:57pm

@tx0c tx0c self-assigned this Sep 22, 2023
robertu7
robertu7 suggested changes Sep 22, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/Forms/EmailSignUpForm/Init.tsx Show resolved Hide resolved
src/views/ArticleDetail/AppreciationButton/index.tsx Outdated Show resolved Hide resolved
@tx0c tx0c requested a review from robertu7 September 24, 2023 16:06
robertu7
robertu7 suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@robertu7 robertu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to add their domain to CSP whitelist:

image

src/components/Context/Turnstile/index.ts Outdated Show resolved Hide resolved
@tx0c tx0c force-pushed the feat/turnstile branch 2 times, most recently from 7008e0e to 6938557 Compare September 25, 2023 07:12
@tx0c tx0c merged commit 4e43553 into develop Oct 4, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/turnstile branch October 4, 2023 19:07
feat(turnstile): Use Cloudflare Turnstile instead of Google reCAPTCHA
4e43553 
resolves #3313

with an embedded copy of @marsidev/react-turnstile to circumvent the React v17 dependency problems
https://github.com/marsidev/react-turnstile/tree/main/packages/lib/src

after React v18, this can be move back to use @marsidev/react-turnstile instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertu7 robertu7 robertu7 approved these changes

Assignees

@tx0c tx0c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Cloudflare Turnstile instead of Google reCAPTCHA
2 participants
@tx0c @robertu7