Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dialog beta #3833

Merged
merged 19 commits into from
Sep 21, 2023
Merged

Fix/dialog beta #3833

merged 19 commits into from
Sep 21, 2023

Conversation

wlliaml
Copy link
Contributor

@wlliaml wlliaml commented Sep 20, 2023

No description provided.

@wlliaml wlliaml requested a review from robertu7 September 20, 2023 12:54
@wlliaml wlliaml requested a review from a team as a code owner September 20, 2023 12:54
@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matters-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 8:46am

src/components/DialogBeta/index.tsx Outdated Show resolved Hide resolved
@wlliaml wlliaml requested a review from robertu7 September 21, 2023 08:18
@wlliaml wlliaml changed the title WIP: Fix/dialog beta Fix/dialog beta Sep 21, 2023
import { AuthWalletFeed, Dialog, WalletAuthForm } from '~/components'
import {
AuthWalletFeed,
Dialog,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DialogBeta

smUpContentNoSpacingBottom={isInPage}
smUpSpaceBetween
<DialogBeta.Footer
// smUpContentNoSpacingBottom={isInPage}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove


import { Media } from '~/components'

import { RoundedButton, TextButton } from '../Buttons'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment. can import from the original one so we can keep track the changes easier.

@wlliaml wlliaml merged commit a0b83da into develop Sep 21, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/DialogBeta branch September 21, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants