fix(TagDigest): remove unused props

thematters · Nov 13, 2024 · 85008e1 · 85008e1
1 parent 843247f
commit 85008e1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/src/components/TagDigest/Feed/index.tsx b/src/components/TagDigest/Feed/index.tsx
@@ -4,14 +4,14 @@ import Link from 'next/link'
 import { TEST_ID } from '~/common/enums'
 import { toPath } from '~/common/utils'
 import { abbr } from '~/common/utils/number/abbr'
-import { CardProps } from '~/components'
 import { TagDigestFeedTagFragment } from '~/gql/graphql'
 
 import styles from './styles.module.css'
 
 export type TagDigestFeedProps = {
   tag: TagDigestFeedTagFragment
-} & CardProps
+  onClick?: () => void
+}
 
 const fragments = {
   tag: gql`
@@ -24,7 +24,7 @@ const fragments = {
   `,
 }
 
-const Feed = ({ tag, ...cardProps }: TagDigestFeedProps) => {
+const Feed = ({ tag, onClick }: TagDigestFeedProps) => {
   const path = toPath({
     page: 'tagDetail',
     tag,
@@ -33,7 +33,7 @@ const Feed = ({ tag, ...cardProps }: TagDigestFeedProps) => {
   const numArticles = abbr(tag.numArticles, 2)
 
   return (
-    <Link {...path} legacyBehavior>
+    <Link {...path} legacyBehavior onClick={onClick}>
       <a className={styles.tag} data-test-id={TEST_ID.DIGEST_TAG_FEED}>
         <span className={styles.name}>{tag.content}</span>&nbsp;
         <span

diff --git a/src/views/Tags/Feed.tsx b/src/views/Tags/Feed.tsx
@@ -1,6 +1,6 @@
 import _get from 'lodash/get'
 
-import { analytics, mergeConnections, toPath } from '~/common/utils'
+import { analytics, mergeConnections } from '~/common/utils'
 import {
   EmptyTag,
   InfiniteScroll,
@@ -75,13 +75,6 @@ const Feed = ({ type }: Props) => {
             <li key={tag.id} className={styles.listItem}>
               <TagDigest.Feed
                 tag={tag}
-                spacing={[8, 0]}
-                href={
-                  toPath({
-                    page: 'tagDetail',
-                    tag, // : node,
-                  }).href
-                }
                 onClick={() =>
                   analytics.trackEvent('click_feed', {
                     type: trackingType,