Skip to content

Commit

Permalink
Merge pull request #1608 from thematters/develop
Browse files Browse the repository at this point in the history
merge "develop" into "stage" for v3.17.1
  • Loading branch information
devformatters authored Nov 4, 2020
2 parents 52e16bf + 19ea14d commit 84e01c2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "matters-web",
"version": "3.17.0",
"version": "3.17.1",
"description": "codebase of Matters' website",
"sideEffects": false,
"author": "Matters <[email protected]>",
Expand Down
8 changes: 8 additions & 0 deletions src/components/Editor/BottomBar/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
border-radius: var(--spacing-x-tight) var(--spacing-x-tight) 0 0;
box-shadow: 0 -4px 16px rgba(0, 0, 0, 0.08);

@media (--sm-up) {
@mixin border-top-grey;

position: sticky;
border-radius: 0;
box-shadow: none;
}

& button {
flex: 1 1 0;
height: 100%;
Expand Down
4 changes: 2 additions & 2 deletions src/views/ArticleDetail/EditMode/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface EditModeProps {
}

const EditMode: React.FC<EditModeProps> = ({ article, onSaved }) => {
const isSmallUp = useResponsive('sm-up')
const isLargeUp = useResponsive('lg-up')

// staging editing data
const [cover, editCover] = useState<Asset>()
Expand Down Expand Up @@ -131,7 +131,7 @@ const EditMode: React.FC<EditModeProps> = ({ article, onSaved }) => {
<Content article={article} />
</section>

{!isSmallUp && (
{!isLargeUp && (
<EditModeBottomBar
article={article}
cover={cover}
Expand Down
4 changes: 2 additions & 2 deletions src/views/Me/DraftDetail/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const EmptyLayout: React.FC = ({ children }) => (
)

const DraftDetail = () => {
const isSmallUp = useResponsive('sm-up')
const isLargeUp = useResponsive('lg-up')
const router = useRouter()
const id = getQuery({ router, key: 'draftId' })

Expand Down Expand Up @@ -144,7 +144,7 @@ const DraftDetail = () => {
<Editor draft={draft} update={update} upload={upload} />
</Layout.Spacing>

{!isSmallUp && <BottomBar draft={draft} />}
{!isLargeUp && <BottomBar draft={draft} />}
</Layout.Main>
)
}
Expand Down

0 comments on commit 84e01c2

Please sign in to comment.