Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-85] Add AppId to applications #276

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[PLAY-85] Add AppId to applications #276

wants to merge 4 commits into from

Conversation

koncar
Copy link
Contributor

@koncar koncar commented Mar 12, 2023

Description

We want to be able to use AppId in resources of applications.
In case Spec.Id exists we add label app-id to all resources, and also modify resource names to contain ID aside from AppName.
Modify all filters and fetch methods to work with it

  • Fix Github Action execution of tests to not give false positive outcome
  • Fix tests that accumilated over time because of false positive results

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@koncar koncar force-pushed the add-app-id-label branch from e839726 to b70df8b Compare March 16, 2023 15:29
@koncar koncar force-pushed the add-app-id-label branch from 1b13ffa to 2585946 Compare March 16, 2023 16:00
@koncar koncar changed the title Add AppId label [PLAY-85] Add AppId to applications Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants