Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheiaCoV_ONT_PHB Influenza Track #233

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

jrotieno
Copy link
Contributor

@jrotieno jrotieno commented Oct 27, 2023

Closes N/A

🛠️ Changes Being Made

This PR adds an Influenza track onto the TheiaCoV_ONT_PHB workflow.

Uses the same IRMA task that performs assembly of influenza viruses but with module specification for ONT reads.

Impacted Workflows/Tasks

  • TheiaCoV_ONT_PHB
  • TheiaCoV_Illumina_PE
  • IRMA task

🧠 Context and Rationale

Many public health laboratories are increasingly generating Oxford Nanopore data, hence the need for an influenza track to handle such inputs within

📋 Workflow/Task Steps

Inputs

Required inputs are:
read1
samplename

Recommended optional inputs:
organism - Required when analyzing pathogens other than SARS-CoV-2, e.g. "HIV" and "flu"
primer_bed - Was previously a required input, now an optional input as not required for flu analysis. However, it is required for other pathogens processed by the workflow such as HIV and SARS-CoV-2
reference_genome also required for HIV analysis

Outputs

Impacted Outputs

Additional outputs added are:
irma_version
irma_type
irma_subtype
irma_ha_segment
irma_na_segment
abricate_flu_type
abricate_flu_subtype
abricate_flu_results
abricate_flu_database
abricate_flu_version

🧪 Testing

Locally

Works as expected

Terra

Works as expected.
SARS-CoV-2: https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/Global_tree_testing/job_history/e485251a-be75-497e-be95-7ed6368071f8
HIV: https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/Global_tree_testing/job_history/e5dcd4b7-aa91-4057-9290-b5267433a3f2
Flu H1N1: https://app.terra.bio/#workspaces/cdph-terrabio-taborda-manual/Global_tree_testing/job_history/7a136cfd-e05c-4a8e-927c-78bd36c37514

Scenarios for Reviewer to Test

Test with H3N2 and cases that would fail QC for other pathogens

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@sage-wright sage-wright linked an issue Nov 15, 2023 that may be closed by this pull request
Copy link
Contributor

@frankambrosio3 frankambrosio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankambrosio3 frankambrosio3 merged commit ac7ba44 into main Nov 21, 2023
9 checks passed
@jrotieno jrotieno deleted the jro_theiacov_ont_flu_clean branch November 21, 2023 08:48
@sage-wright sage-wright restored the jro_theiacov_ont_flu_clean branch November 21, 2023 15:03
@sage-wright sage-wright deleted the jro_theiacov_ont_flu_clean branch November 28, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an influenza module to TheiaCoV_ONT
3 participants