Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update PHB version #204

Merged
merged 3 commits into from
Oct 2, 2023
Merged

update PHB version #204

merged 3 commits into from
Oct 2, 2023

Conversation

sage-wright
Copy link
Member

Closes

🛠️ Changes Being Made

🧠 Context and Rationale

📋 Workflow/Task Steps

Inputs

Outputs

🧪 Testing

Locally

Terra

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@kapsakcj
Copy link
Contributor

kapsakcj commented Oct 2, 2023

Doing a quick test in Terra to see the expected PHB version output: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/479d4854-d3f1-4b94-b7ac-d0bb21ea3a3e

tbp-parser docker change looks good, I have not tested myself but trust that it is OK

kapsakcj
kapsakcj previously approved these changes Oct 2, 2023
View reviewed changes
@kapsakcj kapsakcj merged commit 64d5810 into main Oct 2, 2023
16 checks passed
@kapsakcj kapsakcj deleted the smw-version-dev branch October 2, 2023 16:50
@sage-wright sage-wright changed the title update version update PHB version Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapsakcj kapsakcj kapsakcj approved these changes

Assignees

@kapsakcj kapsakcj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sage-wright @kapsakcj