Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -n to echo command in kmc to avoid new line #201

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

frankambrosio3
Copy link
Contributor

Closes

πŸ› οΈ Changes Being Made

🧠 Context and Rationale

πŸ“‹ Workflow/Task Steps

Inputs

Outputs

πŸ§ͺ Testing

Locally

Terra

πŸ”¬ Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

@cimendes
Copy link
Member

cimendes commented Oct 2, 2023

The TheiaCoV_ONT run was a success with the exception of the MPXV runs as I failed to pass on the correct dataset tag to nextclade, so the error is unrelated to the changes in this PR.

8 runs on TheiaProk_ONT were aborted after several days of running. KMC outputted genome sizes of > 20 Million basepairs for these sequences. This issue is unrelated to this PR but I still think it's worth taking note.

Regarding the newline issue, this has been successfully fixed by the PR, so once it moves out of draft status I'll be approving it. :)

@frankambrosio3 frankambrosio3 marked this pull request as ready for review October 2, 2023 11:49
@frankambrosio3 frankambrosio3 merged commit 0151682 into main Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants