plasmidfinder task bugfix and updates #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TY @erikwolfsohn for reporting this bug!
🛠️ Changes Being Made
mv
commands verbose🧠 Context and Rationale
Previously, if plasmidfinder identified 2 identical plasmid replicon genes, those genes would not appear in the
plasmidfinder_plasmids
output string. Example:Would results in an output string of
No plasmids detected in database
due to thesort | uniq -u
piping on line 44.After the change, this string now correctly reports all plasmid replicon genes
rep21,rep21
, regardless if they are unique or not.We would prefer our users to quickly see all matches (even if they appear twice/more than once in the assembly)
Also, plasmidfinder essentially runs blast, so it does not need 8 cpus and 16 GBs of RAM.
This applies to all TheiaProk workflows that utilize this task (so all of them)
📋 Workflow/Task Steps
N/A
Inputs
N/A
Outputs
N/A
🧪 Testing
Locally
Only tested in Terra.
Terra
TheiaProk_Illumina_PE successful test: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/1cf771be-2dd1-459b-8440-2b6b35e1080e
TheiaProk_ONT successful test: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/2786992b-0462-49c6-b1f5-0a015b209ed6
🔬 Quality checks
Pull Request (PR) checklist: