-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resfinder improvements, added support for Shigella spp., added XDR Shigella prediction #159
Conversation
… to be run through E.coli pointfinder database, changed output file extensions for TSVs, exposed cpu and memory optional inputs, changed name of 2 input params to be more recognizeable
… to be run through E.coli pointfinder database, changed output file extensions for TSVs, exposed cpu and memory optional inputs, changed name of 2 input params to be more recognizeable
…_resistance which is semicolon delimited output of "<antimicrobial>: <Genetic background>"
…xdr_shigella" which checks for predicted resistance to ceftriazone, azithromycin, ciprofloxacin, trimethoprim, fulfamethozazole, and ampicillin
…w as well as export_taxon_tables task
…E, ONT). also added to export_taxon_tables inputs. renamed call block alias for resfinder in theiaprok_ONT to match other workflows
… to be run through E.coli pointfinder database, changed output file extensions for TSVs, exposed cpu and memory optional inputs, changed name of 2 input params to be more recognizeable
…_resistance which is semicolon delimited output of "<antimicrobial>: <Genetic background>"
…xdr_shigella" which checks for predicted resistance to ceftriazone, azithromycin, ciprofloxacin, trimethoprim, fulfamethozazole, and ampicillin
…w as well as export_taxon_tables task
…E, ONT). also added to export_taxon_tables inputs. renamed call block alias for resfinder in theiaprok_ONT to match other workflows
…DR status output strings; added 6 new string outputs with predicted resistance to 6 drugs in XDR classification
…sted successfully w miniwdl
…ave XDR non-Shigella samples (like E. coli) that would still be relevant to user
…mn. Either "Not Shigella..." or "XDR Shigella" or "Not XDR Shigella"
… same to export_taxon_tables task to input call block within theiaprok_illumina_pe workflow
…NT outputs. also added these inputs to export_taxon_tables call block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will approve upon successful testing & result examination
https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Wright_PHBG_Sandbox/job_history/8a6c0348-79a7-457c-bdd2-bc4f2992e2c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
origin/main
so that is why it appears that there are lots of files changed and commits included in this PR. Do not fear, these changes have mostly been incorporated intomain
already, and I will highlight the files changed that are relevant & brought in with this PR.It seems that resolving merge conflicts has totally un-done the rebase-ing I've done, so the "Files changed" section is much simpler and easier to review.
Setting as a draft until we & CDPH folks are happy with the changes & outputs in TerraCDPH folks are happy, will update everything and start running testsTODOs:
Successful test workflows in Terra
amrfinderplus_testing_sample
data table: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/a4a28496-126a-4dae-b968-56ff79d05bedcdc_xdr_shigella
data table: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/588dc78f-dc5e-431b-84a4-de6ee6230295amrfinderplus_testing_sample
data table but with R1 FASTQ only: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/07870448-5dc5-462b-81d0-720759145303amrfinderplus_testing_sample
data table: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/d7abe191-5dc8-47f5-aa09-4975c764c479kleb_ont
data table: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/b44e14f4-d30d-4b84-9637-5b434d061137shigella_nanopore
data table: https://app.terra.bio/#workspaces/theiagen-validations/curtis-sandbox-theiagen-validations/job_history/34e5b916-ca54-4c5f-8ed4-552f80a78d7eFor all test samples in the
amrfinderplus_testing_sample
data table, I expect similar if not exact results between the ILMN PE, ILMN SE, and FASTA results. There may be minor differences due to assemblies differing between single-end and paired-end inputs, but not drastic differences.🛠️ Changes Being Made
tasks/gene_typing/task_resfinder.wdl
cpu
andmemory
optional inputsmin_id
andcall_PointFinder
resfinder_predicted_pheno_resistance
: Semicolon delimited list of antimicrobial drugs and associated genes and/or point mutations.<drug1>: <gene1>, <gene1>, <point_mutation1>; <drug2>: <gene3>, <gene4>;
resfinder_predicted_xdr_shigella
which has 3 potential output strings:Not Shigella based on gambit_predicted_taxon or user input
Not XDR Shigella
for samples identified as Shigella by GAMBIT or user input BUT does resfinder did not predict resistance to all 6 drugs in XDR definitionXDR Shigella
which is based on predicted resistance to ceftriazone, azithromycin, ciprofloxacin, trimethoprim, sulfamethoxazole, and ampicillin.resfinder_predicted_resistance_Amp
which states eitherResistance
orNo Resistance predicted
based on resfinder resultsresfinder_predicted_resistance_Azm
(same as above)resfinder_predicted_resistance_Axo
(same as above)resfinder_predicted_resistance_Cip
(same as above)resfinder_predicted_resistance_Smx
(same as above)resfinder_predicted_resistance_Tmp
(same as above)tasks/utilities/task_broad_terra_tools.wdl
4 workflows: TheiaProk_Illumina_PE, SE, ONT, and FASTA
export_taxon_table
s call blocks🧠 Context and Rationale
Mainly wanted to add support for running all Shigella species through the PointFinder E. coli database. Also wanted the ability to easily detect XDR Shigella samples based on the CDC definition here: https://emergency.cdc.gov/han/2023/han00486.asp
The WDL task now parses the predicted phenotypes TSV file (NOT the species-specific predicted phenotypes TSV) to look for genes conferring resistance to these drugs, and will output a string telling the user if it meets all parts of the definition.
📋 Workflow/Task Steps
N/A
Inputs
N/A
Outputs
N/A
🧪 Testing
Locally
Tested the WDL task without issue using
miniwdl
Terra
Will follow up with more thorough tests once we get feedback from CDPH and make final changes
🔬 Quality checks
Pull Request (PR) checklist: