-
Notifications
You must be signed in to change notification settings - Fork 10
Created short deployment for test cases #99
base: master
Are you sure you want to change the base?
Created short deployment for test cases #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great works on exploring this, I left some comments while reading it.
scripts/helpers/migration.ts
Outdated
libs: any, | ||
params?: any | ||
) { | ||
return await new Promise(async (resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose for all these await new Promise(async
?
Instead of wrapping them in a promise and use a resolve callback, why we can't just return the updatedInstance
at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While using fs.readFile()
the function had some issue while returning updatedInstance
. So, I used promises.
export async function getRollupUtils(rollupUtilsInstance?: any) { | ||
var rollupUtils: any = !rollupUtilsInstance | ||
? await rollupUtils.deployed() | ||
: rollupUtilsInstance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wrap these checks in a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have to create 3-4 functions for different contracts.
No description provided.