Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Created short deployment for test cases #99

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

thrilok209
Copy link
Collaborator

No description provided.

Copy link
Contributor

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works on exploring this, I left some comments while reading it.

libs: any,
params?: any
) {
return await new Promise(async (resolve, reject) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose for all these await new Promise(async?

Instead of wrapping them in a promise and use a resolve callback, why we can't just return the updatedInstance at the end?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While using fs.readFile() the function had some issue while returning updatedInstance . So, I used promises.

scripts/helpers/migration.ts Outdated Show resolved Hide resolved
export async function getRollupUtils(rollupUtilsInstance?: any) {
var rollupUtils: any = !rollupUtilsInstance
? await rollupUtils.deployed()
: rollupUtilsInstance;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap these checks in a function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to create 3-4 functions for different contracts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants