-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple small quality of life fixes #630
base: master
Are you sure you want to change the base?
Conversation
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
@mrchrisadams This felt like a pretty straightforward change to make, because there's a similar However, when testing with a reeeaaaaallllly long organisation name, I found that the form will just truncate the name to 255 characters without giving any warning. I'm okay with that functionality, but want to make a note that is what will happen with very long descriptions too. |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Old Energy EstimationEco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
Eco-CI Output:
🌳 CO2 Data: |
Thinking out loud, this could also be done through a bit of JavaScript like the other change in this PR. |
@@ -1,4 +1,4 @@ | |||
Dear member of The Green Web Foundation, | |||
Dear member of Green Web Foundation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind using the lower case the here instead removing it @fershad ? I think it reads funny, as there's only one Green Web Foundation. I've expanded on this here, and referenced it in the controlled vocabulary:
@@ -18,7 +18,7 @@ | |||
|
|||
schema_view = get_schema_view( | |||
openapi.Info( | |||
title="Welcome to The Green Web Foundation Partner API ", | |||
title="Welcome to Green Web Foundation Partner API ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as above. Can we please keep the lower case 'the' here, like we do in other places where we refer to the Green Web Foundation in the middle of a sentence?
@@ -1,16 +1,19 @@ | |||
# Installation | |||
|
|||
This installation shows you how to setup the Admin Portal of The Green Web Foundation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
@@ -1,6 +1,6 @@ | |||
# Key concepts | |||
|
|||
The Green Web Foundation offers an API to provide any IP address or domain, and get back a 'green' result indicating that the site or digital service appears to be running on digital powered by green energy, and we have found evidence to support this claim or a 'grey' result where no evidence was found for green energy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to have the 'The' here to be honest, as we're talking about the foundation offering an API, and it's sentence in a paragraph, rather than a the name of the organistion all by itself. Personally, I think it reads a bit funny when we remove the article. This is consistence with the usage I've outlined in the article, where the Mozilla Foundation, another foundation is totally with beginning sentences with 'The' if it makes them read better. I've linked directly to the example below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fershad - I've added a few comments but otherwise this look good, thanks!
This PR: