Put the carbon-txt-preview route behind a flag #624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the use of feature flags to control access to the CarbonTxt preview functionality. It adds the
WaffleFlagMixin
to theCarbonTxtCheckView
class and includes tests to ensure the feature flag works as expected.Feature flag implementation:
apps/accounts/admin_site.py
: AddedWaffleFlagMixin
toCarbonTxtCheckView
and setwaffle_flag
to "carbon-txt-preview". [1] [2]Testing enhancements:
apps/greencheck/tests/views/test_api_carbon_txt.py
: Addedoverride_flag
import and a new test methodtest_carbon_txt_preview_behind_flag
to verify the behavior of the CarbonTxt preview behind the feature flag. [1] [2]Minor cleanup:
apps/accounts/admin_site.py
: Removed unnecessary whitespace inget_app_list
method.