Add support for sentry tracing #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrchrisadams
commented
Sep 19, 2023
| [program:{{ supervisor_gunicorn_app }}] | ||
| directory=/var/www/{{ tgwf_domain_name }}.thegreenwebfoundation.org/current/ | ||
| numprocs=1 | ||
| command=bash ./run_gunicorn.sh | ||
| process_name=%(process_num)02d | ||
| environment=PORT=90%(process_num)02d |
There was a problem hiding this comment.
We don't scale with supervisord - gunicorn has good support for forking subprocesses and threads, and using those to control concurrency, and resource usage, so we do it there instead.
mrchrisadams
force-pushed
the
ca-add-support-for-sentry-tracing
branch
from
ace4c64 to
8d472ac
Compare
mrchrisadams
commented
Sep 19, 2023
| @@ -1,4 +1,4 @@ | |||
| # supervisor can only control processes it started itself. | |||
| # So we need to use exec to replace the parent shell script process | |||
| # that starts pipenv | |||
| exec python -m pipenv run gunicorn greenweb.wsgi -b {{ internal_ip }}:$PORT -t 300 -c gunicorn.conf.py --statsd-host=10.0.0.2:9125 --statsd-prefix=member.app | |||
| exec python -m pipenv run gunicorn greenweb.wsgi -b {{ internal_ip }}:{{ gunicorn_port }} -t 300 -c gunicorn.conf.py --statsd-host=10.0.0.2:9125 --statsd-prefix=member.app | |||
There was a problem hiding this comment.
We set the port explicitly because this allows us to run production and staging apps on the same machine, without port clashes
mrchrisadams
commented
Sep 19, 2023
| @@ -54,7 +54,7 @@ | |||
| # set our identifying credentials | |||
| dsn=sentry_dsn, | |||
| # Set traces_sample_rate. | |||
| traces_sample_rate=sentry_sample_rate, | |||
| traces_sample_rate=float(sentry_sample_rate), | |||
There was a problem hiding this comment.
Sentry seems to expect a float, not a string, so we coerce accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to set Sentry's tracing on our apps on a per machine basis, so we can get an idea of where performance bottlenecks lie.
Previously we had api.TGWF and admin.TGWF running on the same server, but since expanding to more machines, this allows us to serve admin.TGWF (which receives like.. 1000x less traffic) with sentry tracing on the app3 server, where we could run the tracing without blowing through our quota, and api.TGWF on the other machines, where we do not.
This also supports sampling on the API servers, but because admin.TGWF still gets some API traffic, this is currently assumed to be less of a priority.