Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match cache key to invalidate stale data #171

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

denning
Copy link
Contributor

@denning denning commented Jun 11, 2021

Re: Issue #170

Appears that there was a mismatch between the key get and key delete.

@denning
Copy link
Contributor Author

denning commented Jun 11, 2021

I wonder if it's just as simple as this? The get/delete names don't match, so I'd expect that would cause some problems here at least.

Could not reproduce bug due to time constraints - it appears the docs are out of date a bit and and the docker-compose.yml file is unmaintained (I'd be happy to bring the docker files up to date, if you think they'd be useful for anyone.)

@mrchrisadams
Copy link
Member

mrchrisadams commented Jun 12, 2021

LOL, it may well be @denning - I must have been tired when adding that.

I'll try that now, and see if that resolves it.

Docker and docker compose

Yes, it would indeed be helpful to get the dockerfiles updated. I'll create an issue separately, as I spent a bit of time faffing around with this to get github actions working, and some of that work might by relevant. I'd really like to be able to run this with something like gitpod or github codespaces - that would bring down the barriers to entry substantially.

https://github.com/thegreenwebfoundation/admin-portal/blob/master/.github/workflows/run-tests.yml

@mrchrisadams
Copy link
Member

mrchrisadams commented Jun 12, 2021

Oh my. I think that was the issue was the reason. I've checked the naming convention on production and it was indeed missing the s. Thanks for this! I'm going to merge it in.

I've also created an issue for updating the files related to docker:

#173

@mrchrisadams mrchrisadams merged commit 2160b51 into thegreenwebfoundation:master Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants