Update approval step to archive IPs and ASNs

As opposed to deleting them like we did before

apps/accounts/models/hosting.py

@@ -27,6 +27,7 @@
 )
 from ..permissions import manage_provider, manage_datacenter
 from apps.greencheck.choices import StatusApproval, GreenlistChoice
+# import apps.greencheck.models as gc_models
 
 logger = logging.getLogger(__name__)
 
@@ -468,6 +469,26 @@ def mark_as_pending_review(self, approval_request):
 
         return False
 
+    # Queries
+    # set the return type to be a Queryset of the relevant model
+    # import queryset from django
+
+
+    def active_ip_ranges(self) -> models.QuerySet["GreencheckIP"]:
+        """
+        Return the active IP ranges for this provider
+        """
+        return self.greencheckip_set.filter(active=True)
+
+    def active_asns(self) -> models.QuerySet["GreencheckASN"]:
+        """
+        Return the active ASNs for this provider
+        """
+        return self.greencheckasn_set.filter(active=True)
+
+
+    # Properties
+
     def counts_as_green(self):
         """
         A convenience check, provide a simple to let us avoid

apps/accounts/models/provider_request.py

@@ -196,10 +196,14 @@ def approve(self) -> Hostingprovider:
             hp.services.clear()
 
             for asn in hp.greencheckasn_set.all():
-                asn.delete()
+                # TODO: decide about logging this change if it changes 
+                # the state the ASN
+                asn.archive()
 
             for ip_range in hp.greencheckip_set.all():
-                ip_range.delete()
+                # TODO: decide about logging this change if it changes 
+                # the state the ASN
+                ip_range.archive()
 
             for doc in hp.supporting_documents.all():
                 doc.delete()
@@ -237,6 +241,9 @@ def approve(self) -> Hostingprovider:
 
         # create related objects: ASNs
         for asn in self.providerrequestasn_set.all():
+            if matching_inactive_asn := GreencheckASN.objects.filter(active=False, asn=asn.asn, hostingprovider=hp):
+                matching_inactive_asn.update(active=True)
+                continue
             try:
                 GreencheckASN.objects.create(
                     active=True, asn=asn.asn, hostingprovider=hp
@@ -246,8 +253,17 @@ def approve(self) -> Hostingprovider:
                     f"Failed to approve the request `{self}` because the ASN '{asn}' already exists in the database"
                 ) from e
 
-        # create related objects: IP ranges
+        # create related objects: new IP ranges, or activate existing ones 
+        # if inactive matching ones exist in the database
         for ip_range in self.providerrequestiprange_set.all():
+            if matching_inactive_ip := GreencheckIp.objects.filter(active=False,
+                ip_start=ip_range.start,
+                ip_end=ip_range.end,
+                hostingprovider=hp
+                ):
+                matching_inactive_ip.update(active=True)
+                continue
+
             GreencheckIp.objects.create(
                 active=True,
                 ip_start=ip_range.start,