Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite workflow using reusable actions #613

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

archanaserver
Copy link
Contributor

No description provided.

.github/workflows/ruby.yml Outdated Show resolved Hide resolved
.github/workflows/ruby.yml Show resolved Hide resolved
@stejskalleos
Copy link
Contributor

I see it's using Ruby 2.7 and Node 14, I was expecting Ruby 3.0 there as well. Or it is planned for later?

@ekohl
Copy link
Member

ekohl commented Jan 17, 2024

I see it's using Ruby 2.7 and Node 14, I was expecting Ruby 3.0 there as well. Or it is planned for later?

Planned for later. It reads matrix.json from the target version (defaults to develop, so https://github.com/theforeman/foreman/blob/develop/.github/matrix.json). Once we modify that to include 3.0, that will be tested.

You can take this as a base, similar to theforeman/foreman_remote_execution#864

@ekohl
Copy link
Member

ekohl commented Jan 18, 2024

Packit is failing and #615 should resolve that.

@stejskalleos stejskalleos merged commit 6aaa8d2 into theforeman:develop Jan 23, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants