Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running RpcTests on all supported channels #78

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

yallie
Copy link
Collaborator

@yallie yallie commented Nov 27, 2024

Note: this pull request changes only the unit tests.

RpcTests currently test only default channel.
The idea is to subclass RpcTests to test Tcp and Websocket channels explicitly.
With this change it should be easier to test alternative channels such as System.Net.Websockets or QUIC.

Example:

public class RpcTests_Websockets : RpcTests
{
    protected override IServerChannel ServerChannel => new WebsocketServerChannel();

    protected override IClientChannel ClientChannel => new WebsocketClientChannel();

    public RpcTests_Websockets(ServerFixture fixture, ITestOutputHelper helper) : base(fixture, helper)
    {
    }
}

@yallie yallie merged commit 81c1e50 into theRainbird:master Nov 27, 2024
1 check passed
@yallie yallie changed the title Running RpcTests on all supported channel Running RpcTests on all supported channels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant