Feat (i18n) french locale #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gxolin
commented
Oct 17, 2024
| @@ -122,7 +122,7 @@ | |||
| "Defense": "Defense", | |||
| "SensesRange": "Sense", | |||
| "MovementRate": "Move", | |||
| "LiftingCapactiy": "Lifting Capactiy", | |||
| "LiftingCapacity": "Lifting Capacity", | |||
gxolin
commented
Oct 17, 2024
| @@ -91,7 +91,7 @@ export const enum Skill { | |||
|
|
|||
| export const enum DerivedStatistic { | |||
| MovementRate = 'mvr', | |||
| LiftingCapactiy = 'lif', | |||
| LiftingCapacity = 'lif', | |||
There was a problem hiding this comment.
not related, typo in the code while looking for the i18n key typo
gxolin
commented
Oct 17, 2024
Comment on lines
+58
to
62
| { | ||
| "lang": "fr", | ||
| "name": "Français", | ||
| "path": "lang/fr.json" | ||
| } |
|
feel free to @ ping me when the source en.json locale file is in a semi-final state, i'll update this PR to match the en.json file :) |
|
Since we're keeping this open until the localisation file is in a somewhat stable state, I'm going to go ahead and convert this to a draft PR. I'll @ ping when there's not too many more changes to the localisation file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Feature : french sheet internationalization
Description
adding french locale file + enable it in the config + fix one small typo
Related Issue
Closes #75
How Has This Been Tested?
only localy built. I do NOT have a foundry license and can't test in game.
Also, I don't know if I need to change anything else to enable/toggle the french locale to test it.
Checklist:
Additional context
For future translators : Deliberately used the english word for the "Focus" Resource. The closest french word, "Concentration" doesn't works well for this resource. Reverted to Focus since it's also used as is in french.
For a full i18n experience, imperial system should be translated to metrics because french can't grasp the imperial system. But this would be a bit more work than just adding a translation file.