#proposal 86 introduction of feeds navigation (#3916) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated Profile Navigation Menu Added @username's Feed alongside "Wallet" and "Settings" on the right of the Navigation bar. Also implemented "My Feed" for when a user is logged in which is currently commented out. * Top Navigation Implementation Archiving the version of the restyled navigation menu that positions it at the top of the screen. * Revert "Top Navigation Implementation" This reverts commit d246aa9. * Revert "Updated Profile Navigation Menu" This reverts commit b112f20. * Introduction of Primary Navigation These changes introduce a Primary Navigation across the site. The navigation uses an "App Style", bottom tab structure on mobile devices and a more traditional left navigation for Desktop. Full details of the changes are available in the following Steemit posts: Updated Files: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-edited-files New Navigation Component: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-primarynavigation-jsx-and-scss * Bug Fix Fixed a bug for logged out users on a mobile device. They would see an empty secondary navigation under the "Explore" tab. * Performance & Display Tweak Performance: Moved the windowHeight and navHeight calculations into the "Desktop only" scroll section. Display: Tweaked the calculations to improve how the navigation is pinned when taller than the screenHeight. Swapped the "Posts" and "Blog" labels so that "Blog" appears before "Posts" in the Profile Menu. * Spacing Adjustment Adjusted the spacing between icons and their labels. * Hidden "Load More..." Where the "Load more..." link appears on the Notifications screen, it was hidden behind the 2nd level of navigation on Mobile Devices. Additional padding has been introduced to correct this. * Bug Fix Fixed the following issue: 1. Go to your test site or steemitdev 2. Logout 3. Go to the top-level page (or just reload the page?) 4. Login 5. A list of communities gets displayed under, "My Subscriptions", but the communities are not the ones that I subscribe to. The subscriptions were only loaded upon "componentWillMount" with a log in not constituting a remount. Therfore, if the subscriptions have not been set, they should be set upon a componentDidUpdate instead / as well. * Improved Previous Bug Fix Used componentDidUpdate in previous bug fix where componentWillUpdate will give an improved user experience (i.e. with DidUpdate, the "Trending Subscriptions" flashed up before being updated whereas "WillUpdate" has the update prepared. * Revert "Improved Previous Bug Fix" This reverts commit 8259147. * #3918 Bug Fix This bug was preventing the navigation displaying correctly on mobile devices so needed fixing as part of #proposal-86. The chosen solution was to change the method of showing/hiding items to use "display" instead of "visibility". This meant that everything looks the same but the underlying method is different. I also removed an unnecessary parameter when accessing the previousUrl from localStorage. --------- Co-authored-by: the-gorilla-steem <[email protected]>
the-gorilla-steem
merged commit 8bfaab8
into
the-gorilla-steem:#proposal-86-Introduction_of_feeds_navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added @username's Feed alongside "Wallet" and "Settings" on the right of the Navigation bar.
Also implemented "My Feed" for when a user is logged in which is currently commented out.
Archiving the version of the restyled navigation menu that positions it at the top of the screen.
This reverts commit d246aa9.
This reverts commit b112f20.
These changes introduce a Primary Navigation across the site.
The navigation uses an "App Style", bottom tab structure on mobile devices and a more traditional left navigation for Desktop.
Full details of the changes are available in the following Steemit posts:
Updated Files: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-edited-files
New Navigation Component: https://steemit.com/hive-151113/@the-gorilla/proposal-86-change-log-primarynavigation-jsx-and-scss
Fixed a bug for logged out users on a mobile device. They would see an empty secondary navigation under the "Explore" tab.
Performance: Moved the windowHeight and navHeight calculations into the "Desktop only" scroll section.
Display: Tweaked the calculations to improve how the navigation is pinned when taller than the screenHeight.
Swapped the "Posts" and "Blog" labels so that "Blog" appears before "Posts" in the Profile Menu.
Adjusted the spacing between icons and their labels.
Where the "Load more..." link appears on the Notifications screen, it was hidden behind the 2nd level of navigation on Mobile Devices. Additional padding has been introduced to correct this.
Fixed the following issue:
The subscriptions were only loaded upon "componentWillMount" with a log in not constituting a remount. Therfore, if the subscriptions have not been set, they should be set upon a componentDidUpdate instead / as well.
Used componentDidUpdate in previous bug fix where componentWillUpdate will give an improved user experience (i.e. with DidUpdate, the "Trending Subscriptions" flashed up before being updated whereas "WillUpdate" has the update prepared.
This reverts commit 8259147.
This bug was preventing the navigation displaying correctly on mobile devices so needed fixing as part of #proposal-86.
The chosen solution was to change the method of showing/hiding items to use "display" instead of "visibility". This meant that everything looks the same but the underlying method is different.
I also removed an unnecessary parameter when accessing the previousUrl from localStorage.