Update p4_branch #3

thaprau · 2021-04-26T06:49:06Z

No description provided.

It appears that the linking from the column titles of the table of the Summary tab to the Quantile plot has been broken for a while now. Left over code fragments from this were removed and the links were fixed.

…t-links Fix links to quantile plot from summary table

That class creates the directory in its constructor, so let's also remove it there in the close() method.

If we did not start benchmarking at all (for example because tool was not found), the call to benchmark.tool.close() was missing. This meant that the multiprocessing pool for the tool-info module was not closed and produced an ugly (but harmless) stack trace on process termination.

We can make use of subprocess.run() and universal_newlines=True in most cases to avoid for example manual decode() calls.

We now use subprocess.run and universal_newlines=True. This also removes the last call to decode_to_string, but we keep it if some external tool-info modules still call it.

This seems possible now due to new react-scripts version.

We actually do not use it anymore since 4f562f3

The former is included in Python's standard library.

Fixes sosy-lab#717

This adds trailing commas in function signatures, which is good for reducing diff noise.

The "obvious" way to write the code was not supported on Python 3.5, so we had to use a fallback.

This syntax was introduced in Python 3.6.

glob.glob actually does not provide a way to match for example either "2" or "10", the pattern we created in such a case would match either "2", "1", "0", or ",". This could lead to matching the wrong cores when cores with multi-digit numbers were used.

The path to table-generator was not escaped at all, so even whitespace was a problem, and the paths to the XML files were wrong in case they contained a ' character. Now we use a proper escaping method, which also avoids quotes in the common case where they are not needed.

(e.g., that all memory regions have the same amount of cores)

This was added in Python 3.6 and is nicer to read.

This syntax from Python 3.6 is much nicer to read. In this commit, only single-line expressions are converted. The changes were automatically created with flynt.

Created automatically with flynt.

Created automatically with flynt and then manually edited to keep to line length.

Introducing an auxiliary variable often makes the code easier to read and better understandable.

Cases like "\n".join(...) are not allowed in f-strings due to the backslash. However, for appending a suffix string concatenation is also fine and the resulting code might actually even be easier to read than before.

These were cases that flynt did not touch because the expressions were too complex, so I did it manually.

This is directly supported by the logging module and evaluated lazily.

Fixing line length, indentation, and unnecessary string concatenation.

Update fork

lachnerm and others added 30 commits April 10, 2021 13:15

Fix links to quantile plot from summary table

b6a6cb1

It appears that the linking from the column titles of the table of the Summary tab to the Quantile plot has been broken for a while now. Left over code fragments from this were removed and the links were fixed.

Merge pull request sosy-lab#720 from sosy-lab/fix-summary-quantile-pl…

269cdbb

…t-links Fix links to quantile plot from summary table

Remove leftover console.log statements

d6eba4c

Refactoring: move cleanup of log dir to OutputHandler

b8f3ee0

That class creates the directory in its constructor, so let's also remove it there in the close() method.

Do not leave useless empty ZIP for logs if all runs are skipped

08cc7a3

Avoid trailing whitespace in text file for results

838668d

Simplify usage of subprocess in tool-info modules

5aafa9d

We can make use of subprocess.run() and universal_newlines=True in most cases to avoid for example manual decode() calls.

More cases of universal_newlines=True instead of manual decode/encode

2b53a53

Simplify subprocess logic in handling of benchexec --commit

a533f69

We now use subprocess.run and universal_newlines=True. This also removes the last call to decode_to_string, but we keep it if some external tool-info modules still call it.

Small simplifications of decode/encode

a199ce9

Replace subprocess.check_call() with run()

314eec6

Update all direct JS dependencies (no major updates)

b4e8432

Update transitive JS dependencies

f295fc6

Update react-scripts

043919e

Update of a JS dev dependency to solve security warning

0874437

Major upgrade of node-sass

e46518b

This seems possible now due to new react-scripts version.

Major upgrade to eslint-config-prettier

bc6f08f

Remove imports-loader from JS dependencies

7ec371b

We actually do not use it anymore since 4f562f3

Add changelog for next release 3.7

db9c354

Use venv instead of virtualenv in release.sh

6d6662b

The former is included in Python's standard library.

Install build dependencies in the venv that we use for building

16ed655

Release 3.7

28d86ef

Prepare version number for next development cycle.

14c8e00

Bump minimum required Python version to 3.6

a31da2e

Fixes sosy-lab#717

Reformat code for syntax in Python 3.6

77f7509

This adds trailing commas in function signatures, which is good for reducing diff noise.

Simplify date handling in util.read_local_time()

8e9d529

The "obvious" way to write the code was not supported on Python 3.5, so we had to use a fallback.

Add thousands separator to huge number literals

1a2119f

This syntax was introduced in Python 3.6.

Add more Python versions to AppVeyor and Travis CI

c86a4aa

Remove workaround from AppVeyor config for Python 3.5

307d0b8

PhilippWendler and others added 24 commits April 22, 2021 08:30

remove unused import

4fcf659

Fix small bug from 838668d: desired newline was stripped away

7506b8c

remove duplicate space (print adds its own)

35d5504

Remove unused import fallback for Python < 3.3

fabb7d0

Avoid useless string formatting

5d35ee7

Simplify some logic for ensuring a symmetric machine architecture

2cfc0a3

(e.g., that all memory regions have the same amount of cores)

Introduce auxiliary variable to reduce repetition

edf940b

Simplify printing by using print() feature for concatenation

efac69e

Replace string formatting with % with f-strings

0dc65d3

This was added in Python 3.6 and is nicer to read.

Simplify string formatting with manual repr calls with f-strings

a8cc132

Replace str.format() calls with f-strings

f58b7d6

This syntax from Python 3.6 is much nicer to read. In this commit, only single-line expressions are converted. The changes were automatically created with flynt.

Replace str.format() calls for multi-line strings with f-strings

dfe6d26

Created automatically with flynt.

Replace str.format() calls for long strings with f-strings

a691e87

Created automatically with flynt and then manually edited to keep to line length.

Rewrite some string formattings with complex expressions

1964189

Introducing an auxiliary variable often makes the code easier to read and better understandable.

Replace str.format() calls with f-strings except for complex suffixes

030831e

Cases like "\n".join(...) are not allowed in f-strings due to the backslash. However, for appending a suffix string concatenation is also fine and the resulting code might actually even be easier to read than before.

Replace remaining str.format() calls with f-strings

b3238d5

These were cases that flynt did not touch because the expressions were too complex, so I did it manually.

fix typo

48cb7e5

Simplify ternary expressions where condition and one result are the same

265253f

In logging statements, use string formatting instead of concatenation

8f158e7

This is directly supported by the logging module and evaluated lazily.

Remove useless string concatenation

dc6f0ad

Reformat long strings for argument description of benchexec

73e8098

Fixing line length, indentation, and unnecessary string concatenation.

Merge pull request #2 from sosy-lab/master

bb7356b

Update fork

thaprau merged commit e58fb89 into bench_p4 Apr 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update p4_branch #3

Update p4_branch #3

thaprau commented Apr 26, 2021

Update p4_branch #3

Update p4_branch #3

Conversation

thaprau commented Apr 26, 2021