Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: bump promql engine and fix fallout #8000

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

MichaHoffmann
Copy link
Contributor

@MichaHoffmann MichaHoffmann commented Dec 17, 2024

  • bump to new promql-engine version and fix fallout
  • new promql-engine makes it possible to provide more options at runtime
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/bump-promql-engine-fix-fallout branch from 9856716 to dc62876 Compare December 17, 2024 11:22
* bump to new promql-engine version and fix fallout
* new promql-engine makes it possible to provide more options at runtime

Signed-off-by: Michael Hoffmann <[email protected]>
@MichaHoffmann MichaHoffmann force-pushed the mhoffmann/bump-promql-engine-fix-fallout branch from dc62876 to d32de64 Compare December 17, 2024 11:32
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we can now add custom options more easily without worrying about breaking Prometheus compatibility.

@MichaHoffmann MichaHoffmann enabled auto-merge (squash) December 17, 2024 16:28
@MichaHoffmann MichaHoffmann merged commit 1ca8292 into main Dec 17, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants