sidecar: fix limit mintime #7970
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/fix-sidecar-limit-min-time
branch
from
794278b to
6f8aa18
Compare
pedro-stanaka
approved these changes
Dec 9, 2024
|
Can you add some description how this fixes the issue? |
It was just a bug, the limit is supposed to be lower bound and I treated it as upper bound |
fpetkovski
approved these changes
Dec 9, 2024
yeya24
approved these changes
Dec 10, 2024
i think yes, its not a great bug |
saswatamcode
approved these changes
Dec 10, 2024
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Michael Hoffmann <[email protected]>
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
added a commit
that referenced
this pull request
Dec 11, 2024
* Fix potential deadlock in hedging request (#7962) Signed-off-by: SungJin1212 <[email protected]> * sidecar: fix limit mintime (#7970) Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> * Cut patch release v0.37.2 Signed-off-by: Saswata Mukherjee <[email protected]> * Fix changelog Signed-off-by: Saswata Mukherjee <[email protected]> --------- Signed-off-by: SungJin1212 <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]> Co-authored-by: SungJin1212 <[email protected]> Co-authored-by: Michael Hoffmann <[email protected]>
MichaHoffmann
added a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Michael Hoffmann <[email protected]> Signed-off-by: Saswata Mukherjee <[email protected]>
MichaHoffmann
added a commit
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Michael Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification