Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7514 sanity #7967

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter fix
Signed-off-by: Miklós Földényi <mfoldenyi@cloudera.com>
  • Loading branch information
mfoldenyi committed Dec 7, 2024
commit 22b4c857fdb9b2755a441a67f31a0c50c2b42874
3 changes: 2 additions & 1 deletion pkg/block/fetcher_test.go
Original file line number Diff line number Diff line change
@@ -8,7 +8,6 @@
"context"
"encoding/json"
"fmt"
"github.com/stretchr/testify/assert"
"io"
"math/rand"
"os"
@@ -19,6 +18,8 @@
"testing"
"time"

"github.com/stretchr/testify/assert"

"github.com/go-kit/log"
"github.com/oklog/ulid"
"github.com/pkg/errors"
@@ -1223,7 +1224,7 @@
outputChannel := make(chan ulid.ULID)
defer close(outputChannel)

timeout, _ := context.WithTimeout(context.Background(), time.Second*5)

Check failure on line 1227 in pkg/block/fetcher_test.go

GitHub Actions / Linters (Static Analysis) for Go

lostcancel: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak (govet)

_, err := lister.GetActiveAndPartialBlockIDs(timeout, outputChannel)

Loading