#7514 Fix channel deadlock in meta sync fetcher #7933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fpetkovski Could you please take a look when you have some time? |
mfoldenyi
force-pushed
the
issue-7514
branch
from
7d6817c to
03a7c44
Compare
GiedriusS
reviewed
Nov 25, 2024
|
@GiedriusS Sure, I will try to implement a test which simulates store errors. it should be running into the deadlock with the original code, but not with the patch. I hopefully can have something by the end of the week. |
Signed-off-by: Miklós Földényi <[email protected]> # Conflicts: # CHANGELOG.md
Signed-off-by: Miklós Földényi <[email protected]>
Signed-off-by: Miklós Földényi <[email protected]>
|
@GiedriusS I created a PR with just the test case to show the error by itself with the code on main: https://github.com/thanos-io/thanos/pull/7966/files The same test case is passing with the provided fix. |
Signed-off-by: Miklós Földényi <[email protected]>
Signed-off-by: Miklós Földényi <[email protected]>
Signed-off-by: Miklós Földényi <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker threads no longer exit on error, instead they collect them into a multiError and keep working.
Fix proposal for #7514
Changes
Changed concurrent worker behavior in case of error in Exists call, they no longer exit on error, instead collect errors in a multiError and continue working.
Verification
I plan to force errors using minio and try to exhaust the threadpool, but I am not yet sure how exactly. Without the patch I should be able to do that, with the patch it should not be possible.