Query-frontend: added error box with warnings #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
|
Hey @MichaHoffmann @yeya24 @GiedriusS can you please take a look at this pull request? |
Signed-off-by: Kartikay <[email protected]>
yeya24
reviewed
Jan 13, 2024
| } | ||
|
|
||
| return warningStrings | ||
| } |
There was a problem hiding this comment.
I wonder if it is better to split the changes and we add warnings to backend response first...
Signed-off-by: Kartikay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #6876
Changes
Made changes in the api which now returns warnings with the response which are then shown in the frontend. Tests by courtesy of @harsh-ps-2003