-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding error box when target not loaded #7034
Conversation
Signed-off-by: Harsh Pratap Singh <[email protected]>
Signed-off-by: Harsh Pratap Singh <[email protected]>
Hey @GiedriusS! |
Thanks for this work! I double-checked and it seems like the root problem is that https://github.com/thanos-io/thanos/blob/main/pkg/ui/react-app/src/pages/targets/ScrapePoolList.tsx#L115C42-L115C50 here in case there are any warnings then we don't show them. Prometheus API has no such field "warnings" in the returned response so the component doesn't show that? Here https://github.com/thanos-io/thanos/blob/main/pkg/ui/react-app/src/pages/targets/ScrapePoolList.tsx#L116 we need to capture the warning and then show it in the |
So the we need to somehow get hold of the warnings from the response, and present it in the UI in form of error boxes. Okay! I am closing this PR as the changes I did are different. If I am able to solve it, I will open another one! Thanks |
Actually I think there is a warnings field in the response of Prometheus API see. I am working on it! |
Changes
Fixes #6876
Added an error box to be shown when the target is loading in Query component.
Verification
Tested in containerised development environment.