Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when merging query stats for chunkFetchDurationSum #6735

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix bug when merging query stats for chunkFetchDurationSum #6735

merged 2 commits into from
Sep 20, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Sep 20, 2023 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

There is a bug when merging query stats for chunkFetchDurationSum field.

Verification

MichaHoffmann
MichaHoffmann approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fpetkovski fpetkovski merged commit a020548 into thanos-io:main Sep 20, 2023
14 checks passed
@yeya24 yeya24 deleted the fix-chunk-fetch-duration-sum-merge branch September 20, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

@fpetkovski fpetkovski fpetkovski approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeya24 @fpetkovski @MichaHoffmann