*: add possibility to add fanout metadata #490
Conversation
Add fanout metadata to Analyze() output. Depends on thanos-io/promql-engine#490. Signed-off-by: Giedrius Statkevičius <[email protected]>
Add a mechanism for adding fanout metadata. This will allow surfacing data that so far is only available in traces and/or logs. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_fanout_metadata
branch
from
72a3bb1 to
148f357
Compare
| @@ -14,6 +15,44 @@ import ( | |||
| "github.com/thanos-io/promql-engine/query" | |||
| ) | |||
|
|
|||
| type metadataKey string | |||
There was a problem hiding this comment.
we have similar pattern in /execution/warning i think, should we move this to /execution/metadata so its similarly structured?
| @@ -37,7 +37,7 @@ func newRelabelOperator( | |||
| next: next, | |||
| funcExpr: funcExpr, | |||
| } | |||
| oper.OperatorTelemetry = model.NewTelemetry(oper, opts) | |||
| oper.OperatorTelemetry = model.NewTelemetry(context.Background(), oper, opts) | |||
There was a problem hiding this comment.
Can we use context from constructor and pass through from engine? This is a bit more work but feels cleaner, we do same with warnings fwiw - if we want to use different kind of metadata someday
| return v.(*FanoutMetadata) | ||
| } | ||
|
|
||
| type FanoutMetadata struct { |
There was a problem hiding this comment.
I think this could just be "Metadata" as its just a map; applications outside could build on top of this map since "fanout" is somewhat a thanos concept that this engine doesnt know about; its more an implementation detail of Select. Thanos could use this to just add fan out metadata in its Select implementation but no need that this library knows what this key contains really.
There was a problem hiding this comment.
On second thought, couldnt this be implemented completely in thanos? As in "create context, add stuff during select, read out in api and add to analysis" kinda way? If we made sure to use same context for "Select" that was used to create the query?
Kinda like we already pass warnings for partial response.
How will you attach select metadata to individual operators? |
Add a mechanism for adding fanout metadata. This will allow surfacing data that so far is only available in traces and/or logs.