engine: fix range query duplicate label handling #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
reviewed
Jan 14, 2024
engine/engine_test.go
Outdated
| @@ -144,6 +144,13 @@ func TestQueriesAgainstOldEngine(t *testing.T) { | |||
| (http_requests_total < 2*http_requests_total) | |||
| )`, | |||
| }, | |||
| { | |||
| name: "duplicate label - top level presentation", | |||
There was a problem hiding this comment.
Can we extend the description with what the expected result here is?
There was a problem hiding this comment.
Added a slightly better test name! The underlying issue is that we would return something like
{} =>
a @ [0]
b @ [3000]
{} =>
c @ [6000]
d @ [9000]
on main since the results appear in different series slots at different times
MichaHoffmann
force-pushed
the
mhoffm-fix-range-query-duplicate-sample-detection
branch
from
db54372 to
515a5a8
Compare
Prometheus seems to care about duplicate samples for label only during the same timestamp. Since our operators might return samples for one result in two different series we need to merge them to one result again. Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffm-fix-range-query-duplicate-sample-detection
branch
from
515a5a8 to
57e4899
Compare
|
I would recommend that we do the mapping between different series IDs in the dedup checking operator. This way two series with the same ID would get mapped to a single ID and we will not break the operator contract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus seems to care about duplicate samples for label only during the same timestamp. Since our operators might return samples for one result in two different series we need to merge them to one result again.