Allow user to specify the location of the json files for the extension #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thamara
reviewed
Oct 4, 2020
Comment on lines
-12
to
+17
| initializeStorageLocation(context.globalStoragePath); | ||
| const configuration = getConfiguration(); | ||
|
|
||
| // if path is '', use global. | ||
| const storagePath = !configuration.saveLocation ? context.globalStoragePath : configuration.saveLocation; | ||
|
|
||
| initializeStorageLocation(storagePath); |
There was a problem hiding this comment.
I think this might lead to some errors in the future. A better approach would be to change to have a global variable in configuration.ts that holds the global storage path. That would be initialized on activate.
With that, getAnnotationFilePath will actually query the configurations and check the configuration set by the user (in a way you already doing here).
This way, all manipulation is done only on configuration.ts, and nowhere else.
It's possible that the actual creation of the path might need to be done on getAnnotationFilePath.
What do you think?
There was a problem hiding this comment.
Great shout!
I'll make the changes soon.
|
Hi @MattBidewell, any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly small PR. Issue 14