[MUST PASS CI 10 CONSECUTIVE TIMES BEFORE MERGING] Workaround for world.Export potentially hanging forever #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to close #1681 with this because I haven't seen that particular issue in for every and it's the most closely related.
Cyberboss
added
Fix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 95.50% 95.50% -0.01%
==========================================
Files 679 679
Lines 145941 145949 +8
Branches 3170 3172 +2
==========================================
+ Hits 139380 139383 +3
- Misses 6073 6079 +6
+ Partials 488 487 -1 |
|
3 succeeded |
|
4 succeeded |
|
above marks 7th run? |
Cyberboss
dismissed
github-actions[bot]’s stale review
The base branch was changed.
|
Next is 8 |
Cyberboss
force-pushed
the
TheLastSpuriousCIError
branch
from
0acd57d
to
690662c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑 DreamMaker API
Worked around an extremely rare BYOND bug where calling
TgsNew()hung forever.Fixed waiting on custom events never returning if TGS restarted while the event was processing.
/🆑
🆑
Fixed a rare race condition when suspending Windows processes.
/🆑
Merge with
[DMDeploy]Closes #1681
Also if this works create a BYOND bug.