Fix lookup_value_regex handling of non string types #1317
+240
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with a very naive fix for #1316
However I did run into some issues:
Breaking regression tests:
drf-spectacular/tests/test_regressions.py
Line 2430 in 0dea78c
And this test looks like it would be affected as well as it strips the UUID information:
drf-spectacular/tests/contrib/test_drf_nested_routers.py
Lines 91 to 94 in 0dea78c
I would be happy to proceed with this PR and make the solution robust, but any early feedback on the issue and advice on the regressions would be appreciated before proceeding!