Skip to content

Commit

Permalink
Moved login via Puppeteer to networkidle2 #178
Browse files Browse the repository at this point in the history
  • Loading branch information
FabienTaillon committed Oct 21, 2024
1 parent d6ee9ea commit ca9d336
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "texei-sfdx-plugin",
"description": "Texeï's plugin for sfdx",
"version": "2.8.0",
"version": "2.8.1",
"author": "Texeï",
"bugs": "https://github.com/texei/texei-sfdx-plugin/issues",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/texei/sharedactivities/enable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default class Enable extends SfCommand<SharedactivitiesEnableResult> {
});
const page = await browser.newPage();
await page.goto(`${instanceUrl}/secur/frontdoor.jsp?sid=${accessToken}`, {
waitUntil: ['domcontentloaded', 'networkidle0'],
waitUntil: ['domcontentloaded', 'networkidle2'],
});

const navigationPromise = page.waitForNavigation();
Expand Down
2 changes: 1 addition & 1 deletion src/commands/texei/sharingcalc/recalculate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default class Recalculate extends SfCommand<SharingcalcRecalculateResult>
const page = await browser.newPage();
await page.goto(
`${instanceUrl}/secur/frontdoor.jsp?sid=${flags['target-org'].getConnection(flags['api-version']).accessToken}`,
{ waitUntil: ['domcontentloaded', 'networkidle0'] }
{ waitUntil: ['domcontentloaded', 'networkidle2'] }
);
const navigationPromise = page.waitForNavigation();

Expand Down
2 changes: 1 addition & 1 deletion src/commands/texei/sharingcalc/resume.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default class Resume extends SfCommand<SharingcalcResumeResult> {
const page = await browser.newPage();
await page.goto(
`${instanceUrl}/secur/frontdoor.jsp?sid=${flags['target-org'].getConnection(flags['api-version']).accessToken}`,
{ waitUntil: ['domcontentloaded', 'networkidle0'] }
{ waitUntil: ['domcontentloaded', 'networkidle2'] }
);
const navigationPromise = page.waitForNavigation();

Expand Down
2 changes: 1 addition & 1 deletion src/commands/texei/sharingcalc/suspend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default class Suspend extends SfCommand<SharingcalcSuspendResult> {
const page = await browser.newPage();
await page.goto(
`${instanceUrl}/secur/frontdoor.jsp?sid=${flags['target-org'].getConnection(flags['api-version']).accessToken}`,
{ waitUntil: ['domcontentloaded', 'networkidle0'] }
{ waitUntil: ['domcontentloaded', 'networkidle2'] }
);
const navigationPromise = page.waitForNavigation();

Expand Down
2 changes: 1 addition & 1 deletion src/shared/standardValueSetHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class StandardValueSetHelper {
this.page = await this.browser.newPage();

await this.page.goto(`${this._connection.instanceUrl}/secur/frontdoor.jsp?sid=${this._connection.accessToken}`, {
waitUntil: ['domcontentloaded', 'networkidle0'],
waitUntil: ['domcontentloaded', 'networkidle2'],
});

this.navigationPromise = this.page.waitForNavigation();
Expand Down

0 comments on commit ca9d336

Please sign in to comment.