Fork for issue #63 #72
Conversation
| @@ -331,7 +331,7 @@ public Path getExerciseChecksumCacheLocation() { | |||
| public ListenableFuture<URI> pasteWithComment(Path path, String comment) | |||
| throws TmcCoreException { | |||
| //checkParameters(path); | |||
There was a problem hiding this comment.
This should have been removed earlier (hups :D ), get rid of it. No commented code.
|
I removed all throws-clauses from ExerciseSubmitter. One thing that strikes me as odd in the current implementation though is that while URIs are now used inside ExerciseSubmitter, when communicating with UrlHelper and UrlCommunicator, URIs have to be converted to Strings or vice versa. Should the rest of the classes in core.communication-package also be refactored to use URIs in place of Strings? |
|
Yes. |
|
Yes, we'd like to refactor all the Stringly typed code to use proper classes instead (see f.ex. testmycode/tmc-netbeans#111 and #70) It seems we forgot to actually create issues for this prior to the course's start. I've now created issues #77 and testmycode/tmc-netbeans#115. |
| import fi.helsinki.cs.tmc.langs.util.TaskExecutor; | ||
| import fi.helsinki.cs.tmc.langs.util.TaskExecutorImpl; | ||
|
|
||
| import com.google.common.base.Optional; | ||
| import edu.emory.mathcs.backport.java.util.Collections; |
There was a problem hiding this comment.
This is the wrong Collections library to use.
|
What's the status of this? Based on previous comments and a quick skim this looks like ready to merge, as soon as it is rebased on top of the current master to remove any conflicts. |
|
Other than the rebasing, should be ready. I'll rebase later today and post an another comment to notify when it's done. |
|
Alright, rebasing done. Let me know if there's more errors and I'll make sure to fix them. Sorry for holding this issue so long. |
Fixes issue #63