Make parsing exercise deadlines thread safe

Exercise#getDeadlineDate was randomly failing because SimpleDateFormat is not thread safe.
testmycode · Oct 14, 2016 · 6f85e5e · 6f85e5e
1 parent 233303c
commit 6f85e5e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/fi/helsinki/cs/tmc/core/domain/Exercise.java b/src/main/java/fi/helsinki/cs/tmc/core/domain/Exercise.java
@@ -20,8 +20,7 @@
 public class Exercise implements Serializable {
 
     private static final Logger logger = LoggerFactory.getLogger(Exercise.class);
-    private static final DateFormat DATE_FORMAT =
-            new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSX");
+    private static final String DATE_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSSX";
 
     private int id;
     private String name;
@@ -138,8 +137,9 @@ public Date getDeadlineDate() {
         if (Strings.isNullOrEmpty(this.getDeadline())) {
             return null;
         }
+        final SimpleDateFormat dateFormatter = new SimpleDateFormat(DATE_FORMAT);
         try {
-            return DATE_FORMAT.parse(this.getDeadline());
+            return dateFormatter.parse(this.getDeadline());
         } catch (ParseException ex) {
             logger.warn("Failed to parse date {}", this.getDeadline(), ex);
             return null;