fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

fpapado · 2024-01-30T19:18:37Z

What:

Follow-up to #143 , and the issue reported at #574.

Mixing export type with export = matchers can throw off TypeScript in some configurations. We do not need to export the matcher as a separate type, since the argument types are available in the matcher already.

I will admit, I do not know the exact combination of configuration that causes this issue. I think it would be desirable to include a test case for it, to ensure that we do not break it accidentally in the future.

The types are doing quite a lot of heavy lifting (types for explicit extend, types on globals/declaration merging, plus being "external" to the source), so perhaps we are not testing all the combinations. I am a bit surprised that we did not get this error in the existing tests, the double export sounds conceptually invalid. The issue at #574 has a reproduction, but paring it down to the size of the existing tests might be best.

Anyway, in terms of compatibility, I am confident that this is the best approach. By avoiding the extra export, we do not confuse TypeScript, and we are back in the previous status quo (exports = matchers only).

Why:

Avoiding unintended type changes, in some environments.

How:

By reverting what the TypeScript error was pointing at:

TS2309: An export assignment cannot be used in a module with other exported elements.

Checklist:

Documentation
Tests
Updated Type Definitions
Ready to be merged

I think this is ready to be merged, but the lack of an inverse test case is bothering me 😅

Please let me know if I can help in any way, and I'll give it a shot!

Mixing export type with export = matchers can throw off TypeScript in some configurations. We do not need to export the matcher as a separate type, since the argument types are available in the matcher already.

andykenward · 2024-01-30T19:22:13Z

types/matchers.d.ts

@@ -1,9 +1,5 @@
 import {ARIARole} from 'aria-query'


Could this be changed to?

import {type ARIARole} from 'aria-query'

fpapado · 2024-02-02T11:28:50Z

Follow-up: we found in #574 that skipLibCheck is what causes this error to silently get ignored from the tests. I don't have a concrete suggestion for what to do with that; perhaps a separate tsconfig without skipLibCheck, but that would need to account for some library type errors that crop up.

Should we merge this to fix current breakage? Gentle ping @gnapse 😌

github-actions · 2024-02-05T13:01:15Z

🎉 This PR is included in version 6.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

##### [`v6.5.0](https://github.com/testing-library/jest-dom/releases/tag/v6.5.0) ##### Features - **toHaveValue:** Asserting aria-valuenow ([#479](testing-library/jest-dom#479)) ([acbf416](testing-library/jest-dom@acbf416)) ##### [`v6.4.8](https://github.com/testing-library/jest-dom/releases/tag/v6.4.8) ##### Bug Fixes - Drop peerDependencies from package.json ([#610](testing-library/jest-dom#610)) ([faf534b](testing-library/jest-dom@faf534b)) ##### [`v6.4.7](https://github.com/testing-library/jest-dom/releases/tag/v6.4.7) ##### Bug Fixes - Type definition of `toHaveClass` ([#611](testing-library/jest-dom#611)) ([5cc6298](testing-library/jest-dom@5cc6298)) ##### [`v6.4.6](https://github.com/testing-library/jest-dom/releases/tag/v6.4.6) ##### Bug Fixes - Support [@starting-style](https://github.com/starting-style) ([#602](testing-library/jest-dom#602)) ([fd9ee68](testing-library/jest-dom@fd9ee68)) ##### [`v6.4.5](https://github.com/testing-library/jest-dom/releases/tag/v6.4.5) ##### Bug Fixes - add js suffix to isEqualWith import ([#599](testing-library/jest-dom#599)) ([e8c8b13](testing-library/jest-dom@e8c8b13)) ##### [`v6.4.4](https://github.com/testing-library/jest-dom/releases/tag/v6.4.4) ##### Bug Fixes - **infra:** codecoverage token addition ([#600](testing-library/jest-dom#600)) ([f03a582](testing-library/jest-dom@f03a582)) ##### [`v6.4.3](https://github.com/testing-library/jest-dom/releases/tag/v6.4.3) ##### Bug Fixes - Updates role support for aria-required attribute in `toBeRequired` ([#590](testing-library/jest-dom#590)) ([20aca33](testing-library/jest-dom@20aca33)) ##### [`v6.4.2](https://github.com/testing-library/jest-dom/releases/tag/v6.4.2) ##### Bug Fixes - Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations ([#575](testing-library/jest-dom#575)) ([a93c0c4](testing-library/jest-dom@a93c0c4)) ##### [`v6.4.1](https://github.com/testing-library/jest-dom/releases/tag/v6.4.1) ##### Bug Fixes - Export type `TestingLibraryMatchers` from "./matchers" ([#576](testing-library/jest-dom#576)) ([dd1c4dd](testing-library/jest-dom@dd1c4dd)) ##### [`v6.4.0](https://github.com/testing-library/jest-dom/releases/tag/v6.4.0) ##### Features - Add toHaveRole matcher ([#572](testing-library/jest-dom#572)) ([f7dc673](testing-library/jest-dom@f7dc673)) ##### [`v6.3.0](https://github.com/testing-library/jest-dom/releases/tag/v6.3.0) ##### Features - Support for regular expressions in toHaveClass ([#563](testing-library/jest-dom#563)) ([9787ed5](testing-library/jest-dom@9787ed5)) ##### [`v6.2.1](https://github.com/testing-library/jest-dom/releases/tag/v6.2.1) ##### Bug Fixes - Standalone types for "./matchers" export and add Bun support ([#566](testing-library/jest-dom#566)) ([5675b86](testing-library/jest-dom@5675b86)) ##### [`v6.2.0](https://github.com/testing-library/jest-dom/releases/tag/v6.2.0) ##### Features - toHaveAccessibleDescription supports aria-description ([#565](testing-library/jest-dom#565)) ([1fb156c](testing-library/jest-dom@1fb156c)) ##### [`v6.1.6](https://github.com/testing-library/jest-dom/releases/tag/v6.1.6) ##### Bug Fixes - Upgrade [@adobe/css-tools](https://github.com/adobe/css-tools) to v4.3.2 ([#553](testing-library/jest-dom#553)) ([b64b953](testing-library/jest-dom@b64b953)) ##### [`v6.1.5](https://github.com/testing-library/jest-dom/releases/tag/v6.1.5) ##### Bug Fixes - support uppercase custom props in toHaveStyle ([#552](testing-library/jest-dom#552)) ([b7b7c6a](testing-library/jest-dom@b7b7c6a)) ##### [`v6.1.4](https://github.com/testing-library/jest-dom/releases/tag/v6.1.4) ##### Bug Fixes - upgrade `@adobe/css-tools` to `4.3.1` to address vulnerability ([#532](testing-library/jest-dom#532)) ([44f1eab](testing-library/jest-dom@44f1eab)) ##### [`v6.1.3](https://github.com/testing-library/jest-dom/releases/tag/v6.1.3) ##### Bug Fixes - proper [@jest/globals](https://github.com/jest/globals) import ([#530](testing-library/jest-dom#530)) ([5b492ac](testing-library/jest-dom@5b492ac)) ##### [`v6.1.2](https://github.com/testing-library/jest-dom/releases/tag/v6.1.2) ##### Bug Fixes - bump [@adobe/css-tools](https://github.com/adobe/css-tools) for ESM support ([#525](testing-library/jest-dom#525)) ([b959a68](testing-library/jest-dom@b959a68)) ##### [`v6.1.1](https://github.com/testing-library/jest-dom/releases/tag/v6.1.1) ##### Bug Fixes - **package.json:** update main and module file paths ([#523](testing-library/jest-dom#523)) ([853a3e5](testing-library/jest-dom@853a3e5)) ##### [`v6.1.0](https://github.com/testing-library/jest-dom/releases/tag/v6.1.0) ##### Features - Publish ESM and CJS (testing-library/jest-dom#519) ##### [`v6.0.1](https://github.com/testing-library/jest-dom/releases/tag/v6.0.1) ##### Bug Fixes - matchers type is making the global expect unsafe ([#513](testing-library/jest-dom#513)) ([bdb34f1](testing-library/jest-dom@bdb34f1)) ##### [`v6.0.0](https://github.com/testing-library/jest-dom/releases/tag/v6.0.0) ##### Features - local types, supporting jest, [@jest/globals](https://github.com/jest/globals), vitest ([#511](testing-library/jest-dom#511)) ([4b764b9](testing-library/jest-dom@4b764b9)) ##### BREAKING CHANGES - Removes the extend-expect script. Users should use the default import path or one of the new test platform-specific paths to automatically extend the appropriate "expect" instance. extend-expect was not documented in the Readme, so this change should have minimal impact. Users can now use the following import paths to automatically extend "expect" for their chosen test platform: - [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) - jest ([@types/jest](https://github.com/types/jest)) - @testing-library/jest-dom/jest-globals - [@jest/globals](https://github.com/jest/globals) - @testing-library/jest-dom/vitest - vitest For example: import '@testing-library/jest-dom/jest-globals' Importing from one of the above paths will augment the appropriate matcher interface for the given test platform, assuming the import is done in a .ts file that is included in the user's tsconfig.json. It's also (still) possible to import the matchers directly without side effects: import \* as matchers from '@testing-library/jest-dom/matchers' - Update kcd-scripts - Drop node < 14

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) | dependencies | major | [`^5.16.4` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/5.17.0/6.6.3) | --- ### Release Notes <details> <summary>testing-library/jest-dom (@testing-library/jest-dom)</summary> ### [`v6.6.3`](https://github.com/testing-library/jest-dom/releases/tag/v6.6.3) [Compare Source](testing-library/jest-dom@v6.6.2...v6.6.3) ##### Bug Fixes - add vitest import when extending vitest matchers ([#646](testing-library/jest-dom#646)) ([5ba0156](testing-library/jest-dom@5ba0156)) ### [`v6.6.2`](https://github.com/testing-library/jest-dom/releases/tag/v6.6.2) [Compare Source](testing-library/jest-dom@v6.6.1...v6.6.2) ##### Bug Fixes - remove recursive type reference in vitest types ([#636](testing-library/jest-dom#636)) ([4468378](testing-library/jest-dom@4468378)) ### [`v6.6.1`](https://github.com/testing-library/jest-dom/releases/tag/v6.6.1) [Compare Source](testing-library/jest-dom@v6.6.0...v6.6.1) ##### Bug Fixes - fix lodash import in to-have-selection.js ([#642](testing-library/jest-dom#642)) ([ced792e](testing-library/jest-dom@ced792e)) ### [`v6.6.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.6.0) [Compare Source](testing-library/jest-dom@v6.5.0...v6.6.0) ##### Features - implement toHaveSelection ([#637](testing-library/jest-dom#637)) ([9b14804](testing-library/jest-dom@9b14804)) ### [`v6.5.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.5.0) [Compare Source](testing-library/jest-dom@v6.4.8...v6.5.0) ##### Features - **toHaveValue:** Asserting aria-valuenow ([#479](testing-library/jest-dom#479)) ([acbf416](testing-library/jest-dom@acbf416)) ### [`v6.4.8`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.8) [Compare Source](testing-library/jest-dom@v6.4.7...v6.4.8) ##### Bug Fixes - Drop peerDependencies from package.json ([#610](testing-library/jest-dom#610)) ([faf534b](testing-library/jest-dom@faf534b)) ### [`v6.4.7`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.7) [Compare Source](testing-library/jest-dom@v6.4.6...v6.4.7) ##### Bug Fixes - Type definition of `toHaveClass` ([#611](testing-library/jest-dom#611)) ([5cc6298](testing-library/jest-dom@5cc6298)) ### [`v6.4.6`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.6) [Compare Source](testing-library/jest-dom@v6.4.5...v6.4.6) ##### Bug Fixes - Support [@starting-style](https://github.com/starting-style) ([#602](testing-library/jest-dom#602)) ([fd9ee68](testing-library/jest-dom@fd9ee68)) ### [`v6.4.5`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.5) [Compare Source](testing-library/jest-dom@v6.4.4...v6.4.5) ##### Bug Fixes - add js suffix to isEqualWith import ([#599](testing-library/jest-dom#599)) ([e8c8b13](testing-library/jest-dom@e8c8b13)) ### [`v6.4.4`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.4) [Compare Source](testing-library/jest-dom@v6.4.3...v6.4.4) ##### Bug Fixes - **infra:** codecoverage token addition ([#600](testing-library/jest-dom#600)) ([f03a582](testing-library/jest-dom@f03a582)) ### [`v6.4.3`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.3) [Compare Source](testing-library/jest-dom@v6.4.2...v6.4.3) ##### Bug Fixes - Updates role support for aria-required attribute in `toBeRequired` ([#590](testing-library/jest-dom#590)) ([20aca33](testing-library/jest-dom@20aca33)) ### [`v6.4.2`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.2) [Compare Source](testing-library/jest-dom@v6.4.1...v6.4.2) ##### Bug Fixes - Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations ([#575](testing-library/jest-dom#575)) ([a93c0c4](testing-library/jest-dom@a93c0c4)) ### [`v6.4.1`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.1) [Compare Source](testing-library/jest-dom@v6.4.0...v6.4.1) ##### Bug Fixes - Export type `TestingLibraryMatchers` from "./matchers" ([#576](testing-library/jest-dom#576)) ([dd1c4dd](testing-library/jest-dom@dd1c4dd)) ### [`v6.4.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.4.0) [Compare Source](testing-library/jest-dom@v6.3.0...v6.4.0) ##### Features - Add toHaveRole matcher ([#572](testing-library/jest-dom#572)) ([f7dc673](testing-library/jest-dom@f7dc673)) ### [`v6.3.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.3.0) [Compare Source](testing-library/jest-dom@v6.2.1...v6.3.0) ##### Features - Support for regular expressions in toHaveClass ([#563](testing-library/jest-dom#563)) ([9787ed5](testing-library/jest-dom@9787ed5)) ### [`v6.2.1`](https://github.com/testing-library/jest-dom/releases/tag/v6.2.1) [Compare Source](testing-library/jest-dom@v6.2.0...v6.2.1) ##### Bug Fixes - Standalone types for "./matchers" export and add Bun support ([#566](testing-library/jest-dom#566)) ([5675b86](testing-library/jest-dom@5675b86)) ### [`v6.2.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.2.0) [Compare Source](testing-library/jest-dom@v6.1.6...v6.2.0) ##### Features - toHaveAccessibleDescription supports aria-description ([#565](testing-library/jest-dom#565)) ([1fb156c](testing-library/jest-dom@1fb156c)) ### [`v6.1.6`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.6) [Compare Source](testing-library/jest-dom@v6.1.5...v6.1.6) ##### Bug Fixes - Upgrade [@adobe/css-tools](https://github.com/adobe/css-tools) to v4.3.2 ([#553](testing-library/jest-dom#553)) ([b64b953](testing-library/jest-dom@b64b953)) ### [`v6.1.5`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.5) [Compare Source](testing-library/jest-dom@v6.1.4...v6.1.5) ##### Bug Fixes - support uppercase custom props in toHaveStyle ([#552](testing-library/jest-dom#552)) ([b7b7c6a](testing-library/jest-dom@b7b7c6a)) ### [`v6.1.4`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.4) [Compare Source](testing-library/jest-dom@v6.1.3...v6.1.4) ##### Bug Fixes - upgrade `@adobe/css-tools` to `4.3.1` to address vulnerability ([#532](testing-library/jest-dom#532)) ([44f1eab](testing-library/jest-dom@44f1eab)) ### [`v6.1.3`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.3) [Compare Source](testing-library/jest-dom@v6.1.2...v6.1.3) ##### Bug Fixes - proper [@jest/globals](https://github.com/jest/globals) import ([#530](testing-library/jest-dom#530)) ([5b492ac](testing-library/jest-dom@5b492ac)) ### [`v6.1.2`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.2) [Compare Source](testing-library/jest-dom@v6.1.1...v6.1.2) ##### Bug Fixes - bump [@adobe/css-tools](https://github.com/adobe/css-tools) for ESM support ([#525](testing-library/jest-dom#525)) ([b959a68](testing-library/jest-dom@b959a68)) ### [`v6.1.1`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.1) [Compare Source](testing-library/jest-dom@v6.1.0...v6.1.1) ##### Bug Fixes - **package.json:** update main and module file paths ([#523](testing-library/jest-dom#523)) ([853a3e5](testing-library/jest-dom@853a3e5)) ### [`v6.1.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.1.0) [Compare Source](testing-library/jest-dom@v6.0.1...v6.1.0) ##### Features - Publish ESM and CJS (testing-library/jest-dom#519) ### [`v6.0.1`](https://github.com/testing-library/jest-dom/releases/tag/v6.0.1) [Compare Source](testing-library/jest-dom@v6.0.0...v6.0.1) ##### Bug Fixes - matchers type is making the global expect unsafe ([#513](testing-library/jest-dom#513)) ([bdb34f1](testing-library/jest-dom@bdb34f1)) ### [`v6.0.0`](https://github.com/testing-library/jest-dom/releases/tag/v6.0.0) [Compare Source](testing-library/jest-dom@v5.17.0...v6.0.0) ##### Features - local types, supporting jest, [@jest/globals](https://github.com/jest/globals), vitest ([#511](testing-library/jest-dom#511)) ([4b764b9](testing-library/jest-dom@4b764b9)) ##### BREAKING CHANGES - Removes the extend-expect script. Users should use the default import path or one of the new test platform-specific paths to automatically extend the appropriate "expect" instance. extend-expect was not documented in the Readme, so this change should have minimal impact. Users can now use the following import paths to automatically extend "expect" for their chosen test platform: - [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) - jest ([@types/jest](https://github.com/types/jest)) - @testing-library/jest-dom/jest-globals - [@jest/globals](https://github.com/jest/globals) - @testing-library/jest-dom/vitest - vitest For example: import '@testing-library/jest-dom/jest-globals' Importing from one of the above paths will augment the appropriate matcher interface for the given test platform, assuming the import is done in a .ts file that is included in the user's tsconfig.json. It's also (still) possible to import the matchers directly without side effects: import \* as matchers from '@testing-library/jest-dom/matchers' - Update kcd-scripts - Drop node < 14 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/58 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

Remove errant export of GetByRoleMatcher

4698615

Mixing export type with export = matchers can throw off TypeScript in some configurations. We do not need to export the matcher as a separate type, since the argument types are available in the matcher already.

andykenward reviewed Jan 30, 2024

View reviewed changes

fpapado changed the title ~~fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configuraitons~~ fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations Jan 30, 2024

fpapado mentioned this pull request Jan 31, 2024

Types breakage in v6.4.0 #574

Closed

import type for ARIARole

d9daafd

gnapse approved these changes Feb 5, 2024

View reviewed changes

Merge branch 'main' into fix/matcher-types-with-by-role-matcher

26b9983

gnapse enabled auto-merge (squash) February 5, 2024 12:55

gnapse merged commit a93c0c4 into testing-library:main Feb 5, 2024
4 checks passed

github-actions bot added the released label Feb 5, 2024

csmartinez22 mentioned this pull request May 23, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.4.2 csmartinez22/csmartinez22.github.io#23

Closed

saileshbro mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.4 saileshbro/DevConnector#354

Closed

lholmquist mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.4 nodeshift/mern-workshop#198

Merged

csmartinez22 mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.4.4 csmartinez22/csmartinez22.github.io#24

Closed

admin-token-bot mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 mongodb/docs-realm#3275

Closed

This was referenced May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 TartejBrothers/SRM-Attendease#35

Merged

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 TartejBrothers/TodoApp-MongoDB#33

Merged

ThomasHeim11 mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 ThomasHeim11/TicketToken#8

Merged

bcgov-devops mentioned this pull request May 24, 2024

chore(deps): [Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 bcgov/nr-results-exam#190

Merged

dmathisen mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 dmathisen/BudgetPlanner#53

Merged

IvanCastroDev mentioned this pull request May 24, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.1.2 to 6.4.5 IvanCastroDev/Blog#71

Open

DannySto mentioned this pull request May 25, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 DannySto/sgr#32

Open

jeremyckahn mentioned this pull request May 25, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 jeremyckahn/chitchatter#300

Merged

saileshbro mentioned this pull request May 25, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 saileshbro/DevConnector#355

Merged

lholmquist mentioned this pull request May 26, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 nodeshift/mern-workshop#200

Closed

csmartinez22 mentioned this pull request May 27, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.4.5 csmartinez22/csmartinez22.github.io#25

Closed

Adedoyin-Emmanuel mentioned this pull request May 27, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.4.5 Adedoyin-Emmanuel/react-weather-app#63

Merged

tsmoreland mentioned this pull request May 27, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.4.5 tsmoreland/spring-react-crm#10

Merged

Arjun31415 mentioned this pull request Sep 13, 2024

[Snyk] Upgrade: , , , , , firebase, moment Arjun31415/amazon-clone#292

Merged

zntb mentioned this pull request Sep 14, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 zntb/ReduxCart#13

Merged

jafin mentioned this pull request Sep 14, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.4.2 to 6.5.0 jafin/react-oidc#16

Open

Arjun31415 mentioned this pull request Sep 14, 2024

[Snyk] Upgrade: , , , , , axios, firebase, moment Arjun31415/amazon-clone#293

Closed

zntb mentioned this pull request Sep 19, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 zntb/Twitch-Clone#9

Merged

SatyaRythm mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: , framer-motion SatyaRythm/react-action-item#5

Open

sagarkumar446 mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: , axios sagarkumar446/multistepapp#6

Merged

SatyaRythm mentioned this pull request Sep 21, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 SatyaRythm/react-action-item#6

Open

sagarkumar446 mentioned this pull request Sep 22, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 sagarkumar446/multistepapp#7

Merged

Tatsuhik-o mentioned this pull request Sep 23, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 Tatsuhik-o/WORDLE#2

Open

Toluwanee mentioned this pull request Sep 25, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.1.6 to 6.5.0 Toluwanee/movie_website_clone#5

Open

ElisBushaj mentioned this pull request Sep 26, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.1.6 to 6.5.0 ElisBushaj/tikhive#4

Merged

simonottosen mentioned this pull request Sep 26, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 simonottosen/cph-security#70

Open

Thareendra2000 mentioned this pull request Sep 27, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 mrmihi/ds-lms-microservices#21

Closed

Alaa-1074002 mentioned this pull request Sep 29, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.5.0 Alaa-1074002/cyber-security-opdracht-3---API-s#21

Open

nerdy-tech-com-gitub mentioned this pull request Oct 23, 2024

[Snyk] Upgrade @testing-library/jest-dom from 5.17.0 to 6.5.0 | Upgrade @testing-library/jest-dom for improved testing nerdy-tech-com-gitub/supabass#3

Open

sahilbhelkar mentioned this pull request Nov 5, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.1.6 to 6.5.0 sahilbhelkar/space#5

Open

jakejack13 mentioned this pull request Nov 6, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.2.1 to 6.5.0 jakejack13/realmeye-extension#61

Closed

Tatsuhik-o mentioned this pull request Nov 7, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.6.1 Tatsuhik-o/WORDLE#3

Open

SatyaRythm mentioned this pull request Nov 7, 2024

[Snyk] Upgrade @testing-library/jest-dom from 6.0.0 to 6.6.1 SatyaRythm/react-action-item#8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

fpapado commented Jan 30, 2024

andykenward Jan 30, 2024

fpapado commented Feb 2, 2024

github-actions bot commented Feb 5, 2024

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

fix: Remove errant export of GetByRoleMatcher, fixing type checking in some TS configurations #575

Conversation

fpapado commented Jan 30, 2024

andykenward Jan 30, 2024

Choose a reason for hiding this comment

fpapado commented Feb 2, 2024

github-actions bot commented Feb 5, 2024